style: Use darker red for anchorjs link #201
Merged
+22
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toshimaru
force-pushed
the
update-anchorjs-style
branch
from
9a989cb to
2f51cc5
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes JavaScript code style and enhances visual consistency for anchor links and method documentation. The changes improve code quality through consistent quote usage and modern syntax while refining the UI appearance.
- JavaScript updates use consistent double quotes and modern object/arrow function syntax
- Anchor link colors now use the site's red color scheme for better visual consistency
- Method documentation layout gains improved readability with responsive left margins
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/assets/js/app.js | Modernizes code style with consistent double quotes, object literal syntax for anchors options, and arrow function callbacks |
| src/_sass/railsdoc.scss | Updates anchor link colors to red theme and adds responsive left margins to method documentation elements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates both the JavaScript and SCSS files to improve code consistency, enhance the appearance of anchor links, and refine the layout of method documentation. The most important changes are grouped below.
JavaScript code improvements:
anchorslibrary inapp.jsfor better clarity and consistency, changing the options assignment to use an object and updating quote usage. Also improved the jQuery selector code style for consistency.SCSS styling enhancements:
.anchorjs-linkto use the$redvariable and a specific red shade on hover, improving visual consistency with the site's color scheme..methodclass styles by adding left margin to.description,.method__aka, and.method__sourceelements, with increased spacing on larger screens for better readability.