Add load theme function to load themes with window context #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Dynamic ECharts Theme Loading
This pull request introduces a new function,
RailsCharts.loadTheme, to improve how ECharts themes are managed and loaded within the gem. When loaded via rails the IIFE of themes seems to miss the context of windows and hencethisbecomesundefined. This PR fixes it by adding a function to dynamically load the themes file, while usingwindowsas contextHow to Use
Users should now import themes by calling the new
RailsCharts.loadThemefunction