This repository was archived by the owner on May 21, 2019. It is now read-only.
Add missing vt100 events #828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also see that working on master preserve previous commit on PR, I'll refork and branch to prevent that in the future :) |
|
Looks awesome, thanks for the help! I usually squash merge so reforking isn't necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some problems with the backspace operation on ssh so I took a crack and found some unsupported events. I added the missing event and the relevant docs links.
I also fixed: #688
For some reason the docs didn't mention
3param...Tested on macOS sierra, ssh to debian jessie.
Also fixed two small react warnings.