This repository was archived by the owner on May 21, 2019. It is now read-only.
Fix alt key #852
Merged
Fix alt key #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-shatskyi
approved these changes
Nov 1, 2016
| if (input.ctrlKey) { | ||
| text = String.fromCharCode(input.keyCode - 64); | ||
| } else if (input.altKey) { | ||
| let char = String.fromCharCode(input.keyCode); |
There was a problem hiding this comment.
Isn't input.key already in the proper case?
There was a problem hiding this comment.
From my testing input.key is the special char macOS generates, ∂ for alt+d for example.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure about this fix. It causes
sleep 10thenalt+dto display the same thing as iniTermwhen in "Alt key = ESC+" mode. I was never able to make vim work the way @alok described in eitherblack-screenoriTerm. @ShockOne would you be able to review this one? I'm not very familiar with the ANSI/escape codes stuff.