deposit and withdraw#12
Closed
Siddharth2207 wants to merge 37 commits intomainfrom
Closed
Conversation
thedavidmeister
requested changes
Aug 20, 2023
Contributor
thedavidmeister
left a comment
thedavidmeister
left a comment
There was a problem hiding this comment.
missing documentation and tests for almost everything here
| spinners = "4.1.0" | ||
| hex = "0.4.3" | ||
| ethers-signers = { version = "2.0.8", features = ["ledger"] } | ||
| tui = "0.19" |
Contributor
There was a problem hiding this comment.
remove if we're not using
| let tokens = tokens ; | ||
| let decimals = decimals ; | ||
|
|
||
| let vault_id = U256::from(H160::random().as_bytes()) ; |
Contributor
There was a problem hiding this comment.
this needs to be an input otherwise we can't have 2 orders pointing to the same vault, which is needed to buy/sell in a loop
| constants : constants | ||
| } ; | ||
|
|
||
| let rain_magic_number = String::from("ff0a89c674ee7874") ; |
Contributor
There was a problem hiding this comment.
use the magic numbers from the meta repo enum
| let rain_magic_number = String::from("ff0a89c674ee7874") ; | ||
|
|
||
| // TODO cbor encode order_meta | ||
| let meta_string = hex::decode( |
Contributor
There was a problem hiding this comment.
use cbor encoding from metadata repo
| ).await ; | ||
|
|
||
| // Reinit Wallet Instance | ||
| let wallet= Ledger::new(HDPath::LedgerLive(0), chain_id).await?; |
Contributor
There was a problem hiding this comment.
can you run cargo fmt over this codebase?
| @@ -0,0 +1,139 @@ | |||
|
|
|||
| @@ -0,0 +1,46 @@ | |||
| use std::{convert::TryFrom, sync::Arc}; | |||
| @@ -0,0 +1,100 @@ | |||
| use clap::Parser; | |||
| @@ -1,29 +1,66 @@ | |||
| use anyhow::Result; | |||
| @@ -0,0 +1,17 @@ | |||
|
|
|||
…ain.orderbook into 2023-07-28-ob-cli
Closed
thedavidmeister
requested changes
Sep 20, 2023
Contributor
thedavidmeister
left a comment
thedavidmeister
left a comment
There was a problem hiding this comment.
this doesn't seem finished to me, lots of logic in ts that should sit in rust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.