Bump the versions of Ruby in the MRI containers. #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larskanis
force-pushed
the
flavorjones/bump-ruby-20250717
branch
from
df22ebb to
edabc59
Compare
larskanis
force-pushed
the
flavorjones/bump-ruby-20250717
branch
from
611b738 to
d863a1a
Compare
|
Thanks @flavorjones! Is there a way for me to test it or should I just wait for the release? |
larskanis
force-pushed
the
flavorjones/bump-ruby-20250717
branch
from
541436f to
b291fed
Compare
This fixes configure test for clock_gettime on ruby-3.2.9 and 3.3.9. Without this the check fails with a linker error. And without HAVE_CLOCK_GETTIME the compilation of process.c fails with undefined variable errors. Taken from here: oneclick/rubyinstaller2-packages@a547657 ruby-3.2.8 and 3.3.8 don't need this additional flag. It otherwise fails with: 16 127.7 /usr/local/rake-compiler/sources/ruby-3.2.9/process.c:8389:13: error: 'c' undeclared (first use in this function) 16 127.7 8389 | c = CLOCK_REALTIME; 16 127.7 | ^ 16 127.7 /usr/local/rake-compiler/sources/ruby-3.2.9/process.c:8389:13: note: each undeclared identifier is reported only once for each function it appears in 16 127.7 /usr/local/rake-compiler/sources/ruby-3.2.9/process.c:8397:13: error: label 'gettime' used but not defined 16 127.7 8397 | goto gettime; 16 127.7 | ^~~~ 16 127.7 /usr/local/rake-compiler/sources/ruby-3.2.9/process.c: In function 'rb_clock_getres': 16 127.7 /usr/local/rake-compiler/sources/ruby-3.2.9/process.c:8620:13: error: 'c' undeclared (first use in this function) 16 127.7 8620 | c = CLOCK_REALTIME; 16 127.7 | ^ 16 127.7 /usr/local/rake-compiler/sources/ruby-3.2.9/process.c:8628:13: error: label 'getres' used but not defined 16 127.7 8628 | goto getres; 16 127.7 | ^~~~ 16 127.7 make: *** [Makefile:468: process.o] Error 1
larskanis
force-pushed
the
flavorjones/bump-ruby-20250717
branch
from
b291fed to
6e1eefc
Compare
|
All green now - looks good to merge! |
marcoroth
added a commit
to marcoroth/herb
that referenced
this pull request
Aug 1, 2025
We need to stay on Ruby 3.4.1 until `rake-compiler-dock` supports Ruby 3.4.5 in the upcoming version `1.10.0` (see rake-compiler/rake-compiler-dock#160, rake-compiler/rake-compiler-dock#156, and rake-compiler/rake-compiler-dock#162)
marcoroth
added a commit
to marcoroth/herb
that referenced
this pull request
Aug 1, 2025
We need to stay on Ruby 3.4.1 until `rake-compiler-dock` supports Ruby 3.4.5 in the upcoming version `1.10.0` of `rake-compiler-dock`. See: * rake-compiler/rake-compiler-dock#160 * rake-compiler/rake-compiler-dock#156 * rake-compiler/rake-compiler-dock#162)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native runtime rubies:
Rbenv (host) rubies:
cc @marcoroth