Skip to content

Conversation

@tsinglinrain
Copy link
Contributor

@tsinglinrain tsinglinrain commented Oct 27, 2025

This PR adds two missing updates from the 2025-09-03 version:
additional_data , makenotion/notion-sdk-js#603
request_id , makenotion/notion-sdk-js#618

In the current 2025-09-03 version, additional_data is always None.
According to the official upgrading guide, it will appear when calling the 2022-06-28 API version and the following conditions are met:

  • The database includes multiple data sources
  • Use database API
  • The parameter passed is database_id

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.49%. Comparing base (7b467fe) to head (b74d698).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
- Coverage   99.50%   99.49%   -0.01%     
==========================================
  Files           7        7              
  Lines         401      395       -6     
==========================================
- Hits          399      393       -6     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsinglinrain
Copy link
Contributor Author

tsinglinrain commented Oct 27, 2025

I’ve noticed the slight coverage drop reported by the CI.
It appears to come from notion_client/helpers.py, which isn’t modified in this PR.
My changes are limited to the client.py and errors.py modules, so the coverage difference should be unrelated.

@ramnes
Copy link
Owner

ramnes commented Oct 27, 2025

Excellent, thanks!

@ramnes ramnes merged commit db4eda7 into ramnes:main Oct 27, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants