Add a "soft-errors" mode for prepare subcommand #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful in certain rebase actions teams with complicated charts may face. Essentially this flag will allow for all existing patches to be applied when preparing even if they would cause errors. This way someone doing a rebase can see all the conflicting patches in one execution. They can either try to fix as many as possible, or opt to temporarily disable them and recreate them.
nicholasSUSE
reviewed
Feb 4, 2025
| Action: prepareCharts, | ||
| Before: setupCache, | ||
| Flags: []cli.Flag{packageFlag, cacheFlag}, | ||
| Flags: []cli.Flag{packageFlag, cacheFlag, softErrorsFlag}, |
There was a problem hiding this comment.
I think you will need to add softErrorsFlag also to make charts Flags (line 282).
make charts command also calls make prepare internally before running.
You will have the same problem later on that stage.
There was a problem hiding this comment.
For now I've excluded charts subcommand intentionally - I'm open to expanding there, I just wanted to put some more consideration into if there should be more DX features around that one.
For now I'd expect - at least on O&B team - we would do something like:
- Find all patches with errors,
- Move those to a
patch-offfolder frompatch, - Be able to run
make chart - Work to recreate/fix the patches that were disabled
nicholasSUSE
approved these changes
Feb 4, 2025
| Action: prepareCharts, | ||
| Before: setupCache, | ||
| Flags: []cli.Flag{packageFlag, cacheFlag}, | ||
| Flags: []cli.Flag{packageFlag, cacheFlag, softErrorsFlag}, |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful in certain rebase actions teams with complicated charts may face. Essentially this flag will allow for all existing patches to be applied when preparing even if they would cause errors. This way someone doing a rebase can see all the conflicting patches in one execution.
They can either try to fix as many as possible, or opt to temporarily disable them and recreate them.