Remove cosign check #187
Merged
Remove cosign check #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briandowns
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former cosign check was implemented by using
slsactl, build-scripts used it to check which image tags were already cosigned sorancher/chartsrepository release process would not overwrite anything fromdockerhubto theprime registry.But
slsactlhas a problem, it needs to be updated with the current cosigned images.There is no frequent updates and I decided to move out of it.
Solution
Implementing
skopeo list-tagsfunctionality to check which image tags are already on the prime registry.Regardless of whether they are cosigned or not, I won't sync them if they already exist there.