Skip to content

Trying anonymous tag listing #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2025
Merged

Trying anonymous tag listing #254

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e079e52
testing anonymous reader
nicholasSUSE Oct 3, 2025
b4aa59f
Merge remote-tracking branch 'upstream/master' into fix-push-oci-2
nicholasSUSE Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 13 additions & 17 deletions pkg/auto/oci.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,14 @@ type checkAssetFunc func(ctx context.Context, regClient *registry.Client, ociDNS
type pushFunc func(helmClient *registry.Client, data []byte, url string) error

type oci struct {
DNS string
user string
password string
helmClient *registry.Client
loadAsset loadAssetFunc
checkAsset checkAssetFunc
push pushFunc
DNS string
user string
password string
helmClient *registry.Client
helmReaderClient *registry.Client // anonymous for Tags
loadAsset loadAssetFunc
checkAsset checkAssetFunc
push pushFunc
}

// UpdateOCI pushes Helm charts to an OCI registry
Expand Down Expand Up @@ -70,6 +71,8 @@ func setupOCI(ctx context.Context, ociDNS, ociUser, ociPass string, debug bool)
return nil, err
}

o.helmReaderClient, _ = registry.NewClient()

o.loadAsset = loadAsset
o.checkAsset = checkAsset
o.push = push
Expand Down Expand Up @@ -133,22 +136,15 @@ func setupHelm(ctx context.Context, ociDNS, ociUser, ociPass string, debug bool)
// Production code with Secure Mode and authentication
default:
logger.Log(ctx, slog.LevelInfo, "production mode")
regClient, err = registry.NewRegistryClientWithTLS(
os.Stdout, // output writer
"", // certFile (none)
"", // keyFile (none)
"", // caFile (none)
false, // insecureSkipTLSverify
"", // registryConfig (use default)
false, // debug
regClient, err = registry.NewClient(
registry.ClientOptDebug(false),
)
if err != nil {
logger.Log(ctx, slog.LevelError, "failed to create registry client")
return nil, err
}
if err = regClient.Login(registryHost,
registry.LoginOptInsecure(false),
registry.LoginOptTLSClientConfig("", "", ""),
registry.LoginOptBasicAuth(ociUser, ociPass)); err != nil {
logger.Log(ctx, slog.LevelError, "failed to login")
return nil, err
Expand Down Expand Up @@ -196,7 +192,7 @@ func (o *oci) update(ctx context.Context, release *options.ReleaseOptions) ([]st

// Check if the asset version already exists in the OCI registry
// Never overwrite a previously released chart!
exists, err := o.checkAsset(ctx, o.helmClient, o.DNS, chart, version)
exists, err := o.checkAsset(ctx, o.helmReaderClient, o.DNS, chart, version)
if err != nil {
return pushedAssets, err
}
Expand Down
Loading