Fix panics in rancher token and rancher server current commands #348
Merged
enrichman merged 1 commit intorancher:v2.9from Feb 8, 2024
Merged
Fix panics in rancher token and rancher server current commands #348enrichman merged 1 commit intorancher:v2.9from
rancher token and rancher server current commands #348enrichman merged 1 commit intorancher:v2.9from
Conversation
andreas-kupries
approved these changes
Feb 8, 2024
Contributor
andreas-kupries
left a comment
There was a problem hiding this comment.
looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix rancher/rancher#44332
As I've moved in this PR only the fix related to the panics. I'm going to then rebase the other PR.
Bug Description
Some workflows will trigger panics due to assignment to nil maps, or a missing check:
To reproduce just run a
rancher server currentwithout any configuration:or run a
rancher loginfollowed by arancher token: