Added linter and removed deprecated and unused packages#357
Merged
enrichman merged 14 commits intorancher:v2.9from Apr 10, 2024
Merged
Added linter and removed deprecated and unused packages#357enrichman merged 14 commits intorancher:v2.9from
enrichman merged 14 commits intorancher:v2.9from
Conversation
enrichman
changed the title
enrichman
requested review from
JonCrowther,
andreas-kupries,
bigkevmcd,
crobby and
pmatseykanets
bigkevmcd
previously approved these changes
Apr 9, 2024
bigkevmcd
left a comment
bigkevmcd
left a comment
There was a problem hiding this comment.
Thanks for the cleanup!
Neither of the two issues are blockers.
Contributor
Author
|
@bigkevmcd thanks for the review! I also found two more unused/old commands. |
bigkevmcd
approved these changes
Apr 10, 2024
enrichman
added a commit
to enrichman/cli
that referenced
this pull request
Apr 10, 2024
* Create go.yml * updated golangci config file * renamed action file * removed unused prompt command * fixed SA6005 (staticcheck): used strings.EqualFold * removed unused monitor package * removed unused funcs and fields * fixed SA1019 (staticcheck): removed deprecations * added missing error checking * fixed linter * removed unused (and unimplemented) commands * added error to getClusterK8sOptions * oneliner err check in displayListServers * removed unused docker dependency
enrichman
added a commit
to enrichman/cli
that referenced
this pull request
Apr 10, 2024
* Create go.yml * updated golangci config file * renamed action file * removed unused prompt command * fixed SA6005 (staticcheck): used strings.EqualFold * removed unused monitor package * removed unused funcs and fields * fixed SA1019 (staticcheck): removed deprecations * added missing error checking * fixed linter * removed unused (and unimplemented) commands * added error to getClusterK8sOptions * oneliner err check in displayListServers * removed unused docker dependency
enrichman
added a commit
that referenced
this pull request
Apr 11, 2024
…ages (#357) (#359) * Added linter and removed deprecated and unused packages (#357) * Create go.yml * updated golangci config file * renamed action file * removed unused prompt command * fixed SA6005 (staticcheck): used strings.EqualFold * removed unused monitor package * removed unused funcs and fields * fixed SA1019 (staticcheck): removed deprecations * added missing error checking * fixed linter * removed unused (and unimplemented) commands * added error to getClusterK8sOptions * oneliner err check in displayListServers * removed unused docker dependency * fixed linting issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref:
rancher/clirancher#43185This PR adds a Github Action that perform a lint, test and build to quick check deprecations and errors.
Edited the
golangci-lintconfig to run the default linters.Removed
"io/ioutil"deprecated package, removed some unused funcs, removed unusedpromptcommand (see #115), fixed error checking.Removed direct dependencies:
The "new"
golang.org/x/text v0.11.0dependency was already present as an indirect dep.