Merged
Conversation
pmatseykanets
approved these changes
May 23, 2024
enrichman
approved these changes
May 24, 2024
Contributor
enrichman
left a comment
enrichman
left a comment
There was a problem hiding this comment.
It shows an error to me:
Do we need to make the team public? It seems already the case, but not sure why it fails then.
I'm approving because the @rancher/collie tag seems to work, so... 🤷
Contributor
Author
|
@enrichman the error was because the team did not have write access to the repository. The EIO team has fixed that for us and now github is saying the file is valid 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the collie team as the codeowner of rancher/cli