Rebase release-2.8.patch1 on top of release-2.8
#11093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This explicitly targets `node_modules/vue/dist/vue.js` to ensure that Dashboard is always exposing the UMD builds of Vue to the `window` object (`shell/core/plugins-loader.js`). For more information on different builds that are available to us, see the vue documentation for explanation of different builds [^1] [^1]: https://v2.vuejs.org/v2/guide/installation#Explanation-of-Different-Builds Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
This bumps the `UI_PLUGIN_API_VERSION` to signal that upcoming changes to UI extensions will be incompatible with older versions of Dashboard. A version of 1.2.0 or higher will be required for extensions that utilize backported Vue 3 features that are available in Vue 2.7. Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
[backport v2.8.next2] [Extensions] Expose UMD Builds of Vue to the `window` Object
* backport e2e tests to 2.8 --------- Co-authored-by: Yonas Berhe <yberhe@Yonass-MacBook-Pro.local> Co-authored-by: Giuseppe Leo <giuseppe.leo@suse.com> Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com>
* Add script and CI job to check that all e2e tests have tags (rancher#10578) --------- Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com> Co-authored-by: Yonas Berhe <yberhe@Yonass-MacBook-Pro.local>
- examples metrics.k8s.io.podmetrics, metrics.k8s.io.nodemetrics, componentstatus - change 1 - when these are watched the BE now sends an error... which we ignore and try to watch again - so handle the error - change 2 - avoid this scenario though by stopping watches that don't have the watch verb - because of this change 1 can only be tested by changing code
1. Switching from a detail page with a watch on a specific resource to the list page where we watch all resources did not unwatch on the specific one 2. Switching to a detail page of a resource that's already in the store should ensure we're watching it
- rancher@9318936 - BUG 1 - Navigating from nodes list to a node detail page unwatches nodes list but doesn't watch new resources - Node's list destroy has a forgetType node - this removes entries from store and unwatches nodes list watch - we clear the fact we're watching the node list once we receieve a resource.stop from socket - There's a race condition, the node we're going to is still in the store... but the find action for this doesn't kick off a watch for the rsource - This was resolved by the change in the find action - BUG 2 - Refreshing on the detail page results in a watch for that specific node - Navigating to the list starts a watch for all nodes, but doesn't stop the individual watch - This was resolved by the change in subscribe - HOWEVER - These fixes could impact how what we watch in other cases where we might call find all and find specific in the same context - Safer to address later
…de-spam [2.8] Handle resources that cannot be watched
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
…pported [backport v2.8.x] rancher#10488 (comment)
[2.8]Add vGpus field in Harvester clusters provision
…tall-removal [backport v2.8.x] Removing legacy apps from cluster tools because they are no longer supported
[backport v2.8.x] Remove v1 tools/pages under the legacy navigation item
* remove v1 monitoring code * fix lint issue * remove monitoring v1 uninstall code + remove v1 uninstall translation strings + simple checks for detail pages in e2e tests to verify integrition of work done * address pr comments * fix unit tests --------- Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
…monitoring [backport v2.8.x] remove v1 monitoring code (rancher#10539)
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
…s-2-8 [2.8] Validate allocatable vGPUs number in Harvester clusters creation
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
[2.8] Assign vGpu id when assigning vGpus to Harvester Cluster
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
[2.8] Select vGpus by id instead of vGpu type
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
[2.8] Limit number of assigned vGPUs to 1 for each Machine Pool
…oard-pr Port drone build tasks to gh workflows + actions
[2.8] Port drone build tasks to gh workflows + actions
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
mantis-toboggan-md
approved these changes
May 22, 2024
7 tasks
This was referenced Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This rebases
release-2.8.patch1on top ofrelease-2.8to ensure that therelease-2.8.patch1branch contains all of the recent changes that were included in the v2.8.4 release of Dashboard 1Checklist
Footnotes
https://github.com/rancher/dashboard/releases/tag/v2.8.4 ↩