Skip to content

Conversation

@martyav
Copy link
Contributor

@martyav martyav commented Mar 22, 2023

Fixes #501

I also did a refresh on the page, for clarity and to conform more closely to the style guides.

  • Note about deprecated flags possibly being listed in the UI if you've upgraded from a previous Rancher version.
  • Addition of rke1-custom-node-cleanup
  • Flags were re-arranged in alphabetical order to match the UI.
  • Style updates, such as contractions, shorter sentences, etc.
  • Which version the flag applies to is added to some flags, in parentheses.
  • Updates to the table, such as:
    • Arranging items alphabetically, as they appear in the Rancher UI
    • Only listing features that were added in the previous major release or later (exception -- fleet, which underwent a major change in behavior between 2.5 and 2.6)
    • Removing the empty "Restart Required" column, with only had marks for 2 deprecated features

Changes applied to 2.7, 2.6, and 2.5 pages. I left the oldest page alone as the changes weren't as relevant.

martyav added 3 commits March 22, 2023 17:42
did a refresh of the feature flag page while waiting for a response to request for blurbs
Co-authored-by: Brad Davidson <brad@oatmail.org>
@martyav martyav marked this pull request as ready for review March 27, 2023 14:58
…to rm things that have been available since before 2.5
@martyav
Copy link
Contributor Author

martyav commented Mar 27, 2023

Upon checking the rancher/rancher repo and release notes, I realized that proxy and dashboard are no longer available on fresh Rancher installs. It would seem they would only be visible if the user has upgraded from a Rancher version from before their removal from the UI.

@martyav
Copy link
Contributor Author

martyav commented Mar 28, 2023

Per rancher/rancher#37142 (comment) I was able to get the information I needed for rke1

@martyav martyav requested a review from brandond March 28, 2023 19:48
@martyav
Copy link
Contributor Author

martyav commented Mar 28, 2023

@snasovich Could you do a tech review on feature-flags.md (or ping someone who would be a good fit)?

@martyav martyav requested a review from btat March 29, 2023 15:31
@martyav martyav requested a review from btat March 29, 2023 19:08
Co-authored-by: Billy Tat <btat@suse.com>
@martyav martyav requested a review from btat March 30, 2023 17:14
@martyav martyav requested a review from snasovich March 31, 2023 19:24
@martyav martyav merged commit 470d730 into rancher:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Four feature flags missing from documentation

3 participants