feat: adding listeners and targets #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: matttrach <matt.trachier@suse.com>
VestigeJ
approved these changes
Apr 17, 2024
matttrach
added a commit
to matttrach/terraform-aws-access
that referenced
this pull request
Apr 17, 2024
* feat: adding listeners and targets * fix: lint --------- Signed-off-by: matttrach <matt.trachier@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds load balancer target groups and listeners.
Conceptually, this is a change where users must consider the application that they are building when making this part of the infrastructure.
There is a slight change to the interface, but none of the example usage was broken, so we are not considering this a breaking change. The access_ips optional variable will be replaced with access_info, a more complex argument, but necessary to facilitate proper creation of the load balancer resources. With this new format we are able to deploy listeners and target groups on the load balancer, then when a server is added we will be able to easily attach it to the load balancer with target group attachment objects.