Skip to content

fix: add acceptance test for protected files #114

@github-actions

Description

@github-actions

This is the main issue tracking #113

Please add labels indicating the release versions eg. 'release/v0'

Please add comments for user issues which this issue addresses.

Description copied from PR:

Related Issue

Addresses #5

Description

Issues Resolved:

  • The file client isn't being set to the default osFileClient. The default client is now set at the beginning of every external function (CRUD).
  • The update method needs to validate that the secret key given can calculate the old id before updating the file. We currently validate the id of the incoming state, but not the current state. A side-effect will be that user's can't change the Hmac secret key, since it is used to calculate the id I think this makes intuitive sense.
  • Updated the documentation and argument parameters to make sure updating the secret key forces recreate of the file. A side-effect of this is that to change your secret key you need to first remove the old file from your config with the old secret key, then add a new resource with the new key (a manual two step operation).

Testing and QOL:

  • Adds an acceptance test to make sure that if someone wants to change a file and doesn't have the correct key that the provider will fail.
  • This PR will also be used to verify releases are published correctly.

Testing

This is an update to the tests, it passes.

Not a breaking change.

Sub-issues

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions