Skip to content

Conversation

@github-actions
Copy link

This pull request cherry-picks the changes from #113 into release/v0

Addresses #115 for #114

WARNING!: to avoid having to resolve merge conflicts this PR is generated with 'git cherry-pick -X theirs'.

Please make sure to carefully inspect this PR so that you don't accidentally revert anything!

Please add the proper milestone to this PR

Copied from main PR:

Related Issue

Addresses #5

Description

Issues Resolved:

  • The file client isn't being set to the default osFileClient. The default client is now set at the beginning of every external function (CRUD).
  • The update method needs to validate that the secret key given can calculate the old id before updating the file. We currently validate the id of the incoming state, but not the current state. A side-effect will be that user's can't change the Hmac secret key, since it is used to calculate the id I think this makes intuitive sense.
  • Updated the documentation and argument parameters to make sure updating the secret key forces recreate of the file. A side-effect of this is that to change your secret key you need to first remove the old file from your config with the old secret key, then add a new resource with the new key (a manual two step operation).

Testing and QOL:

  • Adds an acceptance test to make sure that if someone wants to change a file and doesn't have the correct key that the provider will fail.
  • This PR will also be used to verify releases are published correctly.

Testing

This is an update to the tests, it passes.

Not a breaking change.

* fix: add acceptance test for protected files
* fix: secret key forces recreate
---------

Signed-off-by: matttrach <matt.trachier@suse.com>
(cherry picked from commit a839769)
@github-actions github-actions bot requested a review from a team as a code owner August 28, 2025 05:36
@matttrach matttrach changed the title fix: add acceptance test for protected files fix: resolve client and protection flaws Aug 28, 2025
@matttrach matttrach self-assigned this Aug 28, 2025
@matttrach matttrach merged commit 0291bc4 into release/v0 Aug 28, 2025
@matttrach matttrach deleted the backport-113-release-v0 branch August 28, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants