fix: correct the rc calculation #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: matttrach <matt.trachier@suse.com>
This was referenced Aug 28, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Aug 28, 2025
Signed-off-by: matttrach <matt.trachier@suse.com> (cherry picked from commit e3164d8)
matttrach
added a commit
that referenced
this pull request
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Addresses #5
Description
The rc version is getting a repeating "-rc-rc-rc" with every release. It is also calculating the rc based on the last release rather than the next one. This is due to the way we isolate the patch version in the script. Now we increment the minor if there isn't already an rc in place. In practice we should probably just manually tag the first rc of the expected next version just to get the ball rolling.
Testing
actionlint
Not a breaking change.