Skip to content

Move username validation to happen before manage-users check #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2025
Merged

Move username validation to happen before manage-users check #1016

merged 1 commit into from
Aug 7, 2025

Conversation

@JonCrowther
Copy link
Contributor

@JonCrowther JonCrowther commented Aug 6, 2025

Problem

The username validation currently gets bypassed with the manage-users verb.

Solution

Move the validation check for usernames above the manage-users check

CheckList

  • Test
  • Docs

@JonCrowther JonCrowther self-assigned this Aug 6, 2025
@JonCrowther JonCrowther requested a review from a team as a code owner August 6, 2025 19:33
@JonCrowther JonCrowther requested a review from crobby August 6, 2025 20:09
@JonCrowther JonCrowther merged commit 2bafe7a into rancher:main Aug 7, 2025
2 checks passed
@JonCrowther JonCrowther deleted the username-validation-ignores-manage-users-verb branch August 7, 2025 14:16
This was referenced Aug 7, 2025
Merged
Merged
JonCrowther added a commit to JonCrowther/webhook that referenced this pull request Aug 8, 2025
@JonCrowther
Move username validation to happen before manage-users check (rancher…
d156797 
…#1016)
@JonCrowther JonCrowther mentioned this pull request Aug 8, 2025
Merged
JonCrowther added a commit that referenced this pull request Aug 8, 2025
@JonCrowther
[v0.8] Introduce username validation (#1023)
a06e4d9 
* Add update validation for User.UserName (#943)

* Add update validation for User.UserName

* Fix unit test

* Move username validation to happen before manage-users check (#1016)
JonCrowther added a commit to JonCrowther/webhook that referenced this pull request Aug 11, 2025
@JonCrowther
[v0.8] Introduce username validation (rancher#1023)
02d3f8f 
* Add update validation for User.UserName (rancher#943)

* Add update validation for User.UserName

* Fix unit test

* Move username validation to happen before manage-users check (rancher#1016)
JonCrowther added a commit to JonCrowther/webhook that referenced this pull request Aug 11, 2025
@JonCrowther
[v0.8] Introduce username validation (rancher#1023)
13be96e 
* Add update validation for User.UserName (rancher#943)

* Add update validation for User.UserName

* Fix unit test

* Move username validation to happen before manage-users check (rancher#1016)
JonCrowther added a commit that referenced this pull request Aug 12, 2025
@JonCrowther
[v0.8] Introduce username validation (#1023) (#1024)
5aba5c9 
* Add update validation for User.UserName (#943)

* Add update validation for User.UserName

* Fix unit test

* Move username validation to happen before manage-users check (#1016)
JonCrowther added a commit that referenced this pull request Aug 12, 2025
@JonCrowther
[v0.8] Introduce username validation (#1023) (#1026)
92e525f 
* Add update validation for User.UserName (#943)

* Add update validation for User.UserName

* Fix unit test

* Move username validation to happen before manage-users check (#1016)
This was referenced Nov 19, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmatseykanets pmatseykanets pmatseykanets approved these changes

@crobby crobby crobby approved these changes

Assignees

@JonCrowther JonCrowther

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JonCrowther @pmatseykanets @crobby