Ensure operation is update when validating RKEConfig #1145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmatseykanets
previously approved these changes
Oct 17, 2025
Contributor
pmatseykanets
left a comment
pmatseykanets
left a comment
There was a problem hiding this comment.
The test needs to be adjusted too
Error: pkg/resources/provisioning.cattle.io/v1/cluster/validator_test.go:2857:58: not enough arguments in call to p.validateRKEConfigChanged
jakefhyde
force-pushed
the
52223-fix-prevent-zeroing-rkeconfig
branch
from
989c552 to
9d7a48b
Compare
Contributor
Author
Whoops, updated the tests and committed them, forgot to push. Should be updated now. |
pmatseykanets
approved these changes
Oct 17, 2025
tomleb
approved these changes
Oct 17, 2025
jiaqiluo
approved these changes
Oct 17, 2025
This was referenced Oct 17, 2025
This was referenced Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#52223
Problem
Forgot zero value for objects isn't
nilso create operations were triggering rke config validation.This is causing rancher/rancher#52351 to fail.
Solution
Check
request.Operationwhen performing RKEConfig validation.CheckList