-
Notifications
You must be signed in to change notification settings - Fork 80
Add workflow to release webhook in rancher/charts and rancher/rancher #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3f781fc
Add workflow to release webhook in rancher/charts and rancher/rancher
tomleb f1ec4ab
Migrate to using Github App
tomleb a307869
Prepend to release list in charts
tomleb 142b498
Take v-prefixed version as input
tomleb 65809f1
Add doc block to release-message.sh
tomleb cceae44
Ensure prev and new versions are different
tomleb 4bd0355
Add support for RC to nonRC
tomleb 0458250
Add support RC to non-RC in rancher/rancher
tomleb 536fd61
Fix permissios and shell quote
tomleb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| name: Bump webhook in rancher/charts | ||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| charts_ref: | ||
| description: "Submit PR against the following rancher/charts branch (eg: dev-v2.10)" | ||
| required: true | ||
| default: "dev-v2.10" | ||
| prev_webhook: | ||
| description: "Previous Webhook version (eg: v0.5.0-rc.13)" | ||
| required: true | ||
| default: "" | ||
| new_webhook: | ||
| description: "New Webhook version (eg: v0.5.0-rc.14)" | ||
| required: true | ||
| default: "" | ||
|
|
||
| env: | ||
| CHARTS_REF: ${{ github.event.inputs.charts_ref }} | ||
| PREV_WEBHOOK: ${{ github.event.inputs.prev_webhook }} | ||
| NEW_WEBHOOK: ${{ github.event.inputs.new_webhook }} | ||
|
|
||
| jobs: | ||
| create-charts-pr: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| # Required for vault | ||
| id-token: write | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ github.event.inputs.ref }} | ||
| path: webhook | ||
|
|
||
| - uses: rancher-eio/read-vault-secrets@main | ||
| with: | ||
| secrets: | | ||
| secret/data/github/repo/${{ github.repository }}/github/app-credentials appId | APP_ID ; | ||
| secret/data/github/repo/${{ github.repository }}/github/app-credentials privateKey | PRIVATE_KEY | ||
|
|
||
| # Fetch github token just for the charts repository | ||
| - uses: actions/create-github-app-token@v1 | ||
| id: app-token | ||
| with: | ||
| app-id: ${{ env.APP_ID }} | ||
| private-key: ${{ env.PRIVATE_KEY }} | ||
| repositories: | | ||
| charts | ||
|
|
||
| - name: Checkout charts repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| repository: ${{ github.repository_owner }}/charts | ||
| token: ${{ steps.app-token.outputs.token }} | ||
| path: charts | ||
| # Allow making git push request later on | ||
| persist-credentials: true | ||
|
|
||
| - name: Configure the committer | ||
| run: | | ||
| cd charts | ||
| user_id=$(gh api "/users/$APP_USER" --jq .id) | ||
| git config --global user.name "$APP_USER" | ||
| git config --global user.email "${user_id}+${APP_USER}@users.noreply.github.com" | ||
| env: | ||
| GH_TOKEN: ${{ steps.app-token.outputs.token }} | ||
| APP_USER: "${{ steps.app-token.outputs.app-slug }}[bot]" | ||
|
|
||
| - name: Install dependencies | ||
| run: sudo snap install yq --channel=v4/stable | ||
|
|
||
| - name: Run release script | ||
| run: | | ||
| cd charts | ||
| BRANCH="bump-webhook-${GITHUB_RUN_ID}-${GITHUB_RUN_ATTEMPT}" | ||
| echo "BRANCH=${BRANCH}" >> $GITHUB_ENV | ||
| git checkout -b "$BRANCH" "$CHARTS_REF" | ||
| ./webhook/.github/workflows/scripts/release-against-charts.sh . "$PREV_WEBHOOK" "$NEW_WEBHOOK" | ||
|
|
||
| - name: Push and create pull request | ||
| env: | ||
| GH_TOKEN: ${{ steps.app-token.outputs.token }} | ||
| run: | | ||
| cd charts | ||
| git push origin "$BRANCH" | ||
|
|
||
| body=$(../webhook/.github/workflows/scripts/release-message.sh "$PREV_WEBHOOK" "$NEW_WEBHOOK") | ||
|
|
||
| gh pr create \ | ||
| --title "[$CHARTS_REF] Bump rancher-webhook to $NEW_WEBHOOK" \ | ||
| --body "$body" \ | ||
| --repo ${{ github.repository_owner }}/charts \ | ||
| --head "${{ github.repository_owner }}:$BRANCH" \ | ||
| --base "$CHARTS_REF" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| name: Bump webhook in rancher/rancher | ||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| rancher_ref: | ||
| description: "Submit PR against the following rancher/rancher branch (eg: main)" | ||
| required: true | ||
| default: "main" | ||
| prev_webhook: | ||
| description: "Previous Webhook version (eg: v0.5.0-rc.13)" | ||
| required: true | ||
| default: "" | ||
| new_webhook: | ||
| description: "New Webhook version (eg: v0.5.0-rc.14)" | ||
| required: true | ||
| default: "" | ||
|
|
||
| env: | ||
| RANCHER_REF: ${{ github.event.inputs.rancher_ref }} | ||
| PREV_WEBHOOK: ${{ github.event.inputs.prev_webhook }} | ||
| NEW_WEBHOOK: ${{ github.event.inputs.new_webhook }} | ||
|
|
||
| jobs: | ||
| create-rancher-pr: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| # Required for vault | ||
| id-token: write | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ github.event.inputs.ref }} | ||
| path: webhook | ||
|
|
||
| - uses: rancher-eio/read-vault-secrets@main | ||
| with: | ||
| secrets: | | ||
| secret/data/github/repo/${{ github.repository }}/github/app-credentials appId | APP_ID ; | ||
| secret/data/github/repo/${{ github.repository }}/github/app-credentials privateKey | PRIVATE_KEY | ||
|
|
||
| # Fetch github token just for the rancher repository | ||
| - uses: actions/create-github-app-token@v1 | ||
| id: app-token | ||
| with: | ||
| app-id: ${{ env.APP_ID }} | ||
| private-key: ${{ env.PRIVATE_KEY }} | ||
| repositories: | | ||
| rancher | ||
|
|
||
| - name: Checkout rancher repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| repository: ${{ github.repository_owner }}/rancher | ||
| token: ${{ steps.app-token.outputs.token }} | ||
| path: rancher | ||
| # Allow making git push request later on | ||
| persist-credentials: true | ||
|
|
||
| - name: Configure the committer | ||
| run: | | ||
| cd rancher | ||
| user_id=$(gh api "/users/$APP_USER" --jq .id) | ||
| git config --global user.name "$APP_USER" | ||
| git config --global user.email "${user_id}+${APP_USER}@users.noreply.github.com" | ||
| env: | ||
| GH_TOKEN: ${{ steps.app-token.outputs.token }} | ||
| APP_USER: "${{ steps.app-token.outputs.app-slug }}[bot]" | ||
|
|
||
| - name: Install dependencies | ||
| run: sudo snap install yq --channel=v4/stable | ||
|
|
||
| - name: Run release script | ||
| run: | | ||
| cd rancher | ||
| BRANCH="bump-webhook-${GITHUB_RUN_ID}-${GITHUB_RUN_ATTEMPT}" | ||
| echo "BRANCH=${BRANCH}" >> $GITHUB_ENV | ||
| git checkout -b "$BRANCH" "$RANCHER_REF" | ||
| ./webhook/.github/workflows/scripts/release-against-rancher.sh . "$NEW_WEBHOOK" | ||
|
|
||
| - name: Push and create pull request | ||
| env: | ||
| GH_TOKEN: ${{ steps.app-token.outputs.token }} | ||
| run: | | ||
| cd rancher | ||
| git push origin $BRANCH | ||
|
|
||
| body=$(../webhook/.github/workflows/scripts/release-message.sh "$PREV_WEBHOOK" "$NEW_WEBHOOK") | ||
|
|
||
| gh pr create \ | ||
| --title "[$RANCHER_REF] Bump rancher-webhook to $NEW_WEBHOOK" \ | ||
| --body "$body" \ | ||
| --repo ${{ github.repository_owner }}/rancher \ | ||
| --head "${{ github.repository_owner }}:$BRANCH" \ | ||
| --base "$RANCHER_REF" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| #!/bin/sh | ||
| # | ||
| # Bumps Webhook version in a locally checked out rancher/charts repository | ||
| # | ||
| # Usage: | ||
| # ./release-against-charts.sh <path to charts repo> <prev webhook release> <new webhook release> | ||
| # | ||
| # Example: | ||
| # ./release-against-charts.sh "${GITHUB_WORKSPACE}" "v0.5.0-rc.13" "v0.5.0-rc.14" | ||
|
|
||
| CHARTS_DIR=$1 | ||
| PREV_WEBHOOK_VERSION=$2 # e.g. v0.5.2-rc.3 | ||
| NEW_WEBHOOK_VERSION=$3 # e.g. v0.5.2-rc.4 | ||
|
|
||
| usage() { | ||
| cat <<EOF | ||
| Usage: | ||
| $0 <path to charts repo> <prev webhook release> <new webhook release> | ||
| EOF | ||
| } | ||
|
|
||
| bump_patch() { | ||
| version=$1 | ||
| major=$(echo "$version" | cut -d. -f1) | ||
| minor=$(echo "$version" | cut -d. -f2) | ||
| patch=$(echo "$version" | cut -d. -f3) | ||
| new_patch=$((patch + 1)) | ||
| echo "${major}.${minor}.${new_patch}" | ||
| } | ||
|
|
||
| validate_version_format() { | ||
| version=$1 | ||
| if ! echo "$version" | grep -qE '^v[0-9]+\.[0-9]+\.[0-9]+(-rc\.[0-9]+)?$'; then | ||
| echo "Error: Version $version must be in the format v<major>.<minor>.<patch> or v<major>.<minor>.<patch>-rc.<number>" | ||
| exit 1 | ||
| fi | ||
| } | ||
|
|
||
| if [ -z "$CHARTS_DIR" ] || [ -z "$PREV_WEBHOOK_VERSION" ] || [ -z "$NEW_WEBHOOK_VERSION" ]; then | ||
| usage | ||
| exit 1 | ||
| fi | ||
|
|
||
tomleb marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| validate_version_format "$PREV_WEBHOOK_VERSION" | ||
| validate_version_format "$NEW_WEBHOOK_VERSION" | ||
|
|
||
| if echo "$PREV_WEBHOOK_VERSION" | grep -q '\-rc'; then | ||
| is_prev_rc=true | ||
| else | ||
| is_prev_rc=false | ||
| fi | ||
|
|
||
| if [ "$PREV_WEBHOOK_VERSION" = "$NEW_WEBHOOK_VERSION" ]; then | ||
| echo "Previous and new webhook version are the same: $NEW_WEBHOOK_VERSION, but must be different" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Remove the prefix v because the chart version doesn't contain it | ||
| PREV_WEBHOOK_VERSION_SHORT=$(echo "$PREV_WEBHOOK_VERSION" | sed 's|^v||') # e.g. 0.5.2-rc.3 | ||
| NEW_WEBHOOK_VERSION_SHORT=$(echo "$NEW_WEBHOOK_VERSION" | sed 's|^v||') # e.g. 0.5.2-rc.4 | ||
|
|
||
| set -ue | ||
|
|
||
| cd "${CHARTS_DIR}" | ||
|
|
||
| # Validate the given webhook version (eg: 0.5.0-rc.13) | ||
| if ! grep -q "${PREV_WEBHOOK_VERSION_SHORT}" ./packages/rancher-webhook/package.yaml; then | ||
| echo "Previous Webhook version references do not exist in ./packages/rancher-webhook/. The content of the file is:" | ||
| cat ./packages/rancher-webhook/package.yaml | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Get the chart version (eg: 104.0.0) | ||
| if ! PREV_CHART_VERSION=$(yq '.version' ./packages/rancher-webhook/package.yaml); then | ||
| echo "Unable to get chart version from ./packages/rancher-webhook/package.yaml. The content of the file is:" | ||
| cat ./packages/rancher-webhook/package.yaml | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [ "$is_prev_rc" = "false" ]; then | ||
| NEW_CHART_VERSION=$(bump_patch "$PREV_CHART_VERSION") | ||
| else | ||
| NEW_CHART_VERSION=$PREV_CHART_VERSION | ||
| fi | ||
|
|
||
| sed -i "s/${PREV_WEBHOOK_VERSION_SHORT}/${NEW_WEBHOOK_VERSION_SHORT}/g" ./packages/rancher-webhook/package.yaml | ||
| sed -i "s/${PREV_CHART_VERSION}/${NEW_CHART_VERSION}/g" ./packages/rancher-webhook/package.yaml | ||
|
|
||
| git add packages/rancher-webhook | ||
| git commit -m "Bump rancher-webhook to $NEW_WEBHOOK_VERSION" | ||
|
|
||
| PACKAGE=rancher-webhook make charts | ||
| git add ./assets/rancher-webhook ./charts/rancher-webhook index.yaml | ||
| git commit -m "make charts" | ||
|
|
||
| # When previous webhook version is an RC, then we want to remove that RC. We keep | ||
| # non-RC version. | ||
| if [ "$is_prev_rc" = "true" ]; then | ||
| CHART=rancher-webhook VERSION=${PREV_CHART_VERSION}+up${PREV_WEBHOOK_VERSION_SHORT} make remove | ||
| git add ./assets/rancher-webhook ./charts/rancher-webhook ./index.yaml | ||
| git commit -m "make remove" | ||
|
|
||
| yq --inplace "del(.rancher-webhook.[] | select(. == \"${PREV_CHART_VERSION}+up${PREV_WEBHOOK_VERSION_SHORT}\"))" release.yaml | ||
| fi | ||
|
|
||
| # Prepends to list | ||
| yq --inplace ".rancher-webhook = [\"${NEW_CHART_VERSION}+up${NEW_WEBHOOK_VERSION_SHORT}\"] + .rancher-webhook" release.yaml | ||
|
|
||
| git add release.yaml | ||
| git commit -m "Add rancher-webhook ${NEW_CHART_VERSION}+up${NEW_WEBHOOK_VERSION_SHORT} to release.yaml" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.