Ensure go telemetry files aren't added to the commit #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflynt
approved these changes
Dec 23, 2024
pmatseykanets
approved these changes
Dec 30, 2024
This was referenced Feb 6, 2025
This was referenced Mar 28, 2025
This was referenced Jul 28, 2025
This was referenced Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go telemetry in go 1.23 are written to
$HOME/.config/go/(or xdg config). Rancher's dapper config points$HOMEto the root of the repo, so running thego generatecommand creates telemetry files which are then added withgit add ..Since we don't want those files in the commit, we remove them before staging the files.