Support for Version Management on Imported RKE2/K3s Clusters #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobby
reviewed
Feb 18, 2025
Collaborator
crobby
left a comment
crobby
left a comment
There was a problem hiding this comment.
Looks pretty good. Would be nice to add a test for mutator.go.
jiaqiluo
force-pushed
the
support-version-management-main
branch
from
254c1d0 to
7ca9821
Compare
jiaqiluo
force-pushed
the
support-version-management-main
branch
from
7ca9821 to
16d917a
Compare
HarrisonWAffel
approved these changes
Feb 18, 2025
crobby
approved these changes
Feb 18, 2025
This was referenced Feb 21, 2025
This was referenced Mar 28, 2025
This was referenced Jul 28, 2025
This was referenced Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
rancher/rancher#41010
Problem
As a new feature, Rancher will allow enabling or disabling version management for imported RKE2/K3s clusters.
A new annotation on the management v3 cluster object will be used to control the cluster-level setting.
Rancher Webhook will ensure that the annotation is correctly set on eligible clusters.
Please refer to the RFC for design details.
Solution
Please refer to the RFC for design details.
Alternatively, the changes are outlined in the
pkg/resources/management.cattle.io/v3/cluster/Cluster.mdfile.CheckList
This PR was also validated by running the binary and pointing it to a Rancher setup.