Skip to content

Update dependencies for k8s 1.32 #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

Update dependencies for k8s 1.32 #672

merged 1 commit into from
Feb 18, 2025

Conversation

@vatsalparekh
Copy link
Contributor

@vatsalparekh vatsalparekh commented Feb 17, 2025

Issue: rancher/rancher#48818

Problem

Solution

CheckList

  • Test
  • Docs

@vatsalparekh vatsalparekh force-pushed the k8s-132-update branch 2 times, most recently from 6cfdeb4 to 75b4ecf Compare February 17, 2025 19:56
@vatsalparekh vatsalparekh marked this pull request as ready for review February 17, 2025 19:58
@vatsalparekh vatsalparekh requested a review from a team as a code owner February 17, 2025 19:58
tomleb
tomleb approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@tomleb tomleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, going to assign someone from Collie for the rule resolver changes just in case.

tomleb
tomleb requested changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@tomleb tomleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bleh, forgot about the kube-version field in the charts. It needs to be bumped as well here: https://github.com/rancher/webhook/blob/main/charts/rancher-webhook/Chart.yaml#L14.

@tomleb tomleb requested a review from JonCrowther February 17, 2025 20:05
@tomleb
Copy link
Contributor

tomleb commented Feb 17, 2025

@JonCrowther added you because we're updating the RuleResolving code, I think that's because the new K8s version added a context.Context to all of these libraries.

JonCrowther
JonCrowther reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@JonCrowther JonCrowther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RuleResolver stuff looks good to me, but the unused parameters need to be fixed

@vatsalparekh vatsalparekh force-pushed the k8s-132-update branch 3 times, most recently from 4873d47 to a7ac7ff Compare February 18, 2025 07:54
crobby
crobby reviewed Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Seems like there are a few unused imports that are preventing the tests from running. Everything else seems good.

crobby
crobby previously approved these changes Feb 18, 2025
View reviewed changes
@vatsalparekh
Update dependencies for k8s 1.32
66cfdf2 
Signed-off-by: Vatsal Parekh <vatsalparekh@outlook.com>
@vatsalparekh vatsalparekh merged commit f449e4b into rancher:main Feb 18, 2025
2 checks passed
This was referenced Feb 18, 2025
Merged
Merged
@vatsalparekh vatsalparekh mentioned this pull request Mar 20, 2025
Merged
This was referenced Mar 28, 2025
Closed
Merged
This was referenced Jul 28, 2025
Merged
Merged
This was referenced Nov 19, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomleb tomleb tomleb approved these changes

@JonCrowther JonCrowther JonCrowther approved these changes

@crobby crobby crobby left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vatsalparekh @tomleb @crobby @JonCrowther