(feat): Cattle Cluster Agent PDB and PC Validation #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarrisonWAffel
force-pushed
the
pc-pdb-validation
branch
2 times, most recently
from
eb001d1 to
c13c570
Compare
jiaqiluo
requested changes
Feb 20, 2025
Member
jiaqiluo
left a comment
jiaqiluo
left a comment
There was a problem hiding this comment.
left a few comments, but overall good
pkg/resources/management.cattle.io/v3/cluster/validator_test.go
Outdated
Show resolved
Hide resolved
pkg/resources/provisioning.cattle.io/v1/cluster/validator_test.go
Outdated
Show resolved
Hide resolved
HarrisonWAffel
force-pushed
the
pc-pdb-validation
branch
from
c13c570 to
9e59c51
Compare
crobby
previously approved these changes
Feb 20, 2025
Collaborator
crobby
left a comment
crobby
left a comment
There was a problem hiding this comment.
Code and tests look nice. I just had some nits on stray apostrphes.
HarrisonWAffel
force-pushed
the
pc-pdb-validation
branch
from
9e59c51 to
7b73c07
Compare
HarrisonWAffel
force-pushed
the
pc-pdb-validation
branch
from
7b73c07 to
6502f96
Compare
crobby
approved these changes
Feb 20, 2025
jiaqiluo
approved these changes
Feb 20, 2025
This was referenced Feb 21, 2025
This was referenced Mar 28, 2025
This was referenced Jul 28, 2025
This was referenced Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#48995
depends on rancher/rancher#49107
Problem
A new feature is being introduced to Rancher which allows users to define a Pod Disruption Budget and Priority Class on the v1.Cluster and v3.Cluster objects to better ensure HA of the cattle cluster agent. By default this feature will be disabled in v2.11. In order to prevent use of the new fields added to the cluster objects when the feature is disabled, as well as to prevent incorrect configuration of the PC and PDB, additional validation needs to be added to the webhook.
Solution
Add additional logic to the validators for the v1.Cluster, v3.Cluster, and settings resources.
CheckList