Do not validate PC and PDB settings if they have not been customized #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallardduck
approved these changes
Mar 5, 2025
jiaqiluo
approved these changes
Mar 5, 2025
Member
jiaqiluo
left a comment
jiaqiluo
left a comment
There was a problem hiding this comment.
It seems impossible for newSetting to be a nil point.
LGMT.
crobby
approved these changes
Mar 5, 2025
This was referenced Mar 5, 2025
This was referenced Mar 28, 2025
This was referenced Jul 28, 2025
This was referenced Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/backup-restore-operator#642, rancher/rancher#48995
Problem
When the backup restore operator attempts to restore a snapshot taken from a rancher version including the PC and PDB feature, the webhook will attempt to validate the
cluster-agent-default-priority-classandcluster-agent-default-pod-disruption-budgetsettings even if they have not been customized. This results in a json marshaling error, blocking the request. This issue will only reproduce when attempting to reapply the default settings json through BRO or manually. Manual reproduction steps can be found in the linked BRO issue.Solution
Add a conditional to ensure that the setting is only validated if it has been customized.
CheckList