Skip to content

Conversation

@alegrey91
Copy link
Contributor

@alegrey91 alegrey91 commented Mar 26, 2025

Issue:

There's no issue for this PR

Problem

Currently there's only one way to test the webhook development.
This PR introduces an alternative way to test it by importing the built image into the cluster and patching the webhook deployment.
Credits to @raulcabello and @JonCrowther for suggestion.

CheckList

  • Test
  • Docs

Signed-off-by: Alessio Greggi <alessio.greggi@suse.com>
@alegrey91 alegrey91 marked this pull request as ready for review March 26, 2025 09:33
@alegrey91 alegrey91 requested a review from a team as a code owner March 26, 2025 09:33
Copy link
Contributor

@JonCrowther JonCrowther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

Copy link
Contributor

@tomleb tomleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm not too sure if those changes get overridden by the chart manager in r/r but should work for quick tests at least.

@alegrey91 alegrey91 merged commit e842ed9 into rancher:main Mar 26, 2025
2 checks passed
joshmeranda pushed a commit that referenced this pull request Mar 27, 2025
Signed-off-by: Alessio Greggi <alessio.greggi@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants