Add support for k8s 1.33 #954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitsakala
force-pushed
the
issue_50431
branch
8 times, most recently
from
d04bf6f to
62d0d96
Compare
The CI is failing with terminating namespaces with finalizer kubernetes. This has nothing to with the logic of integration tests
crobby
approved these changes
Jun 23, 2025
ericpromislow
approved these changes
Jun 23, 2025
Contributor
ericpromislow
left a comment
ericpromislow
left a comment
There was a problem hiding this comment.
Looks fine. I disagree with the names in the test, because if we add a third CPC they get awkward. This is where I like using names from an unrelated category, like "lemon-cpc" and "apple-cpc" because they're easy to make unique and stick out when tests fail. But that's not part of this PR, so it's fine.
This was referenced Jun 30, 2025
This was referenced Jul 28, 2025
This was referenced Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : rancher/rancher#50431
Summary
foonot being terminated fully with the finalizerkubernetes. Since we are not deleting the resources at the end of the test, this must be happening. So, changed the codebase to use a unique namespace everytime.