Update to use new interface and amend readme and package. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-e-e
changed the title
mafintosh
reviewed
Feb 5, 2018
| del: function (req) { | ||
| if (verbose) console.log('trying to del', key, req.offset, req.size) | ||
| req.callback() | ||
| } |
There was a problem hiding this comment.
Don't implement write/del, then .deletable and .writable will be false :)
mafintosh
reviewed
Feb 5, 2018
package.json
Outdated
| "random-access-storage": "^1.1.0" | ||
| }, | ||
| "devDependencies": { | ||
| "aws-sdk": "^2.188.0", |
Member
Author
There was a problem hiding this comment.
ah yes it is! thank you for catching that one
|
Nice! You might want to implement destroy as well (just delete the entire object on s3) |
|
Its looking good with the changes @mafintosh has recommended. Adding tests and travis will increase confidence for the package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.