BLD: Fix meson build on Cygwin. (scipy#17993)

Mostly fixing dependency contents and order.
Some inclusion of visibility macros before stdlib headers.

[skip ci]

Author: DWesl

dev.py

@@ -436,6 +436,13 @@ def setup_build(cls, dirs, args):
                 raise RuntimeError("Can't build into non-empty directory "
                                    f"'{build_dir.absolute()}'")
 
+        if sys.platform == "cygwin":
+            # Cygwin only has netlib lapack, but can link against
+            # OpenBLAS rather than netlib blas at runtime.  There is
+            # no libopenblas-devel to enable linking against
+            # openblas-specific functions or OpenBLAS Lapack
+            cmd.extend(["-Dlapack=lapack", "-Dblas=blas"])
+
         build_options_file = (
             build_dir / "meson-info" / "intro-buildoptions.json")
         if build_options_file.exists():
@@ -547,6 +554,11 @@ def install_project(cls, dirs, args):
         with open(dirs.installed / ".gitignore", "w") as f:
             f.write("*")
 
+        if sys.platform == "cygwin":
+            rebase_cmd = ["/usr/bin/rebase", "--database", "--oblivious"]
+            rebase_cmd.extend(Path(dirs.installed).glob("**/*.dll"))
+            subprocess.check_call(rebase_cmd)
+
         print("Installation OK")
         return
 

scipy/integrate/meson.build

@@ -134,7 +134,7 @@ py3.extension_module('_vode',
   link_with: [vode_lib],
   c_args: [numpy_nodepr_api, Wno_unused_variable],
   link_args: version_link_args,
-  dependencies: [lapack, fortranobject_dep],
+  dependencies: [lapack, blas, fortranobject_dep],
   install: true,
   link_language: 'fortran',
   subdir: 'scipy/integrate'

scipy/linalg/meson.build

@@ -65,7 +65,7 @@ py3.extension_module('_fblas',
   [fblas_module, g77_abi_wrappers],
   c_args: numpy_nodepr_api,
   link_args: version_link_args,
-  dependencies: [blas, lapack, fortranobject_dep],
+  dependencies: [lapack, blas, fortranobject_dep],
   install: true,
   link_language: 'fortran',
   subdir: 'scipy/linalg'
@@ -85,7 +85,7 @@ py3.extension_module('_flapack',
   [flapack_module, g77_abi_wrappers],
   c_args: [numpy_nodepr_api, Wno_empty_body],
   link_args: version_link_args,
-  dependencies: [lapack, fortranobject_dep],
+  dependencies: [lapack, blas, fortranobject_dep],
   install: true,
   link_language: 'fortran',
   subdir: 'scipy/linalg'
@@ -210,7 +210,7 @@ cython_blas = py3.extension_module('cython_blas',
   c_args: cython_c_args,
   link_with: fwrappers,
   link_args: version_link_args,
-  dependencies: [blas, lapack, np_dep],
+  dependencies: [lapack, blas, np_dep],
   install: true,
   link_language: 'fortran',
   subdir: 'scipy/linalg'
@@ -225,7 +225,7 @@ cython_lapack = py3.extension_module('cython_lapack',
   c_args: cython_c_args,
   link_with: fwrappers,
   link_args: version_link_args,
-  dependencies: [blas, lapack, np_dep],
+  dependencies: [lapack, blas, np_dep],
   install: true,
   link_language: 'fortran',
   subdir: 'scipy/linalg'

scipy/optimize/_trlib/meson.build

@@ -12,7 +12,7 @@ _trlib = py3.extension_module('_trlib',
     '../../_lib',
     '../../_build_utils/src'
   ],
-  dependencies: [lapack, np_dep],
+  dependencies: [lapack, blas, np_dep],
   link_args: version_link_args,
   install: true,
   subdir: 'scipy/optimize/_trlib'

scipy/optimize/meson.build

@@ -109,7 +109,7 @@ _lbfgsb = py3.extension_module('_lbfgsb',
   c_args: numpy_nodepr_api,
   fortran_args: fortran_ignore_warnings,
   link_args: version_link_args,
-  dependencies: [lapack, fortranobject_dep],
+  dependencies: [lapack, blas, fortranobject_dep],
   install: true,
   link_language: 'fortran',
   subdir: 'scipy/optimize'

scipy/sparse/linalg/_dsolve/meson.build

@@ -199,7 +199,7 @@ _superlu = py3.extension_module('_superlu',
   link_with: [superlu_lib],
   include_directories: ['SuperLU/SRC'],
   link_args: version_link_args,
-  dependencies: [blas, lapack, np_dep],
+  dependencies: [lapack, blas, np_dep],
   install: true,
   subdir: 'scipy/sparse/linalg/_dsolve'
 )

scipy/sparse/linalg/_eigen/arpack/meson.build

@@ -102,7 +102,7 @@ _arpack = py3.extension_module('_arpack',
   c_args: numpy_nodepr_api,
   link_with: [arpack_lib],
   link_args: version_link_args,
-  dependencies: [lapack, fortranobject_dep],
+  dependencies: [lapack, blas, fortranobject_dep],
   install: true,
   link_language: 'fortran',
   subdir: 'scipy/sparse/linalg/_eigen/arpack'

scipy/sparse/linalg/_isolve/meson.build

@@ -73,7 +73,7 @@ _iterative = py3.extension_module('_iterative',
   c_args: numpy_nodepr_api,
   fortran_args: fortran_ignore_warnings,
   link_args: version_link_args,
-  dependencies: [lapack, fortranobject_dep],
+  dependencies: [lapack, blas, fortranobject_dep],
   install: true,
   link_language: 'fortran',
   subdir: 'scipy/sparse/linalg/_isolve'

scipy/sparse/linalg/_propack/meson.build

@@ -109,7 +109,7 @@ foreach ele: elements
     link_with: propack_lib,
     c_args: ['-U_OPENMP', _cpp_Wno_cpp],
     fortran_args: _fflag_Wno_maybe_uninitialized,
-    dependencies: [lapack, fortranobject_dep],
+    dependencies: [lapack, blas, fortranobject_dep],
     link_args: version_link_args,
     install: true,
     link_language: 'fortran',

scipy/special/_faddeeva.cxx

@@ -1,8 +1,8 @@
+#include "_faddeeva.h"
+
 #include <complex>
 #include <cmath>
 
-#include "_faddeeva.h"
-
 using namespace std;
 
 extern "C" {