This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Add test for configuring/disabling default autofocus ability #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranndev
added a commit
that referenced
this pull request
Dec 1, 2019
* Fix type on umd gulp script * 0.1.5 * Update issue templates (#69) * Hotfix 0.1.5 (#63) * Fix type on umd gulp script * 0.1.5 * Update issue templates * Add pull request template (#70) * Add test for configuring/disabling default autofocus ability (#75) * Update package description * Hotfix 0.1.6 (#79) * Hotfix 0.1.5 (#63) * Fix type on umd gulp script * 0.1.5 * Add popup animation * 0.1.6 * Add the codepen example link from readme (#80) * Link the created CodePen bug report boilerplate (#81) * Add default dark theme (#83) * 0.2.0
ranndev
pushed a commit
that referenced
this pull request
Dec 4, 2019
* Hotfix 0.1.5 (#63) * Fix type on umd gulp script * 0.1.5 * Hotfix 0.1.6 (#78) * Add popup animation * 0.1.6 * Release 0.2.0 (#84) * Fix type on umd gulp script * 0.1.5 * Update issue templates (#69) * Hotfix 0.1.5 (#63) * Fix type on umd gulp script * 0.1.5 * Update issue templates * Add pull request template (#70) * Add test for configuring/disabling default autofocus ability (#75) * Update package description * Hotfix 0.1.6 (#79) * Hotfix 0.1.5 (#63) * Fix type on umd gulp script * 0.1.5 * Add popup animation * 0.1.6 * Add the codepen example link from readme (#80) * Link the created CodePen bug report boilerplate (#81) * Add default dark theme (#83) * 0.2.0 * Bump rollup-plugin-typescript2 from 0.25.2 to 0.25.3 Bumps [rollup-plugin-typescript2](https://github.com/ezolenko/rollup-plugin-typescript2) from 0.25.2 to 0.25.3. - [Release notes](https://github.com/ezolenko/rollup-plugin-typescript2/releases) - [Commits](ezolenko/rollup-plugin-typescript2@0.25.2...0.25.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is supposedly a fix for #74 , but then I found that it wasn't really a bug when I added a test.
Related issues
Closes #74
Types of changes
What types of changes does your code introduce to UIGuide?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.