Add LinkType to differenciate different link types#147
Add LinkType to differenciate different link types#147raphlinus merged 3 commits intopulldown-cmark:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
raphlinus
left a comment
There was a problem hiding this comment.
This looks good to me. Of course it is an API breaking change, but I think it's reasonable to unfreeze the API.
I'm still locked out of merge permissions but expect to resolve that soon.
|
Sorry about the merge conflict. I'm going to go ahead and do an 0.2.0 now without it (partly to minimize changes for clients), but there'll be scope to get this in soon. |
|
Ok. Should I resolve the merge conflicts now or are you planning on adding more code that could result in further conflicts? |
|
Hmm, let's try to get stuff in now. Not sure what the release strategy will be but we can figure that out later. |
|
I rebased the |
Fix #141