Skip to content

Add LinkType to differenciate different link types#147

Merged
raphlinus merged 3 commits intopulldown-cmark:masterfrom
oberien:linktype
Nov 11, 2018
Merged

Add LinkType to differenciate different link types#147
raphlinus merged 3 commits intopulldown-cmark:masterfrom
oberien:linktype

Conversation

@oberien
Copy link
Contributor

@oberien oberien commented Sep 13, 2018

Fix #141

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@oberien
Copy link
Contributor Author

oberien commented Sep 13, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

Copy link
Collaborator

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Of course it is an API breaking change, but I think it's reasonable to unfreeze the API.

I'm still locked out of merge permissions but expect to resolve that soon.

@raphlinus
Copy link
Collaborator

Sorry about the merge conflict. I'm going to go ahead and do an 0.2.0 now without it (partly to minimize changes for clients), but there'll be scope to get this in soon.

@oberien
Copy link
Contributor Author

oberien commented Nov 7, 2018

Ok. Should I resolve the merge conflicts now or are you planning on adding more code that could result in further conflicts?

@raphlinus
Copy link
Collaborator

Hmm, let's try to get stuff in now. Not sure what the release strategy will be but we can figure that out later.

@oberien
Copy link
Contributor Author

oberien commented Nov 8, 2018

I rebased the linktype branch on the current master.

@raphlinus raphlinus merged commit 07863e9 into pulldown-cmark:master Nov 11, 2018
@oberien oberien deleted the linktype branch November 11, 2018 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants