Updates to use powershell language opts #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
reviewed
Aug 1, 2025
| DEFAULT_RIG_OPTS = { | ||
| max_length: 5, | ||
| min_length: 2, | ||
| forbidden: Parser::RESERVED_VARIABLE_NAMES.map {|e| e[1..-1]} |
Contributor
There was a problem hiding this comment.
Not a blocker; Could we track down if we need this old var or not, and whether all of the entries here are covered in the old new setup 👀
adfoster-r7
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the script to make use of keywords for Powershell added as part of rapid7/rex-random_identifier#17.
Before
It was manually defining its own limited forbidden list using the
Parser::RESERVED_VARIABLE_NAMES.After
Now it uses the
language: :powershelloption, which tells rex-random_identifier to use the comprehensivePowershellOptsthat includes:Verification