Require passing memory resources to from_libcudf methods #20171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Column.from_libcudf, Table.from_libcudf, and TableWithMetadata.from_libcudf methods to require both stream and DeviceMemoryResource parameters instead of making them optional. This enforces explicit memory resource management and prevents accidental use of default/None values throughout the codebase. Key changes: - Remove default parameter values (=None, =*) from method signatures - Remove internal _get_stream() and _get_memory_resource() processing - Update unpack_from_memoryviews function to accept stream parameter - All 265+ from_libcudf call sites now explicitly provide both parameters This ensures consistent and explicit memory resource handling across all pylibcudf operations, eliminating potential memory management issues from implicit parameter defaults. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
Python
bdice
reviewed
Oct 2, 2025
mroeschke
approved these changes
Oct 3, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #14229
Checklist