otpbits.md: revision number -> revision code #1415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor nit - for consistency. I suspect 'revision number' was their original name, when they were purely sequential. Also mention this register stores other things too - currently 3 features not related to the revision code. Not sure if this is really needed, but it improves the 'discoverability' of this information slightly.
|
I guess this needs to be merged after #1370 ? |
Good point - yes, assuming the footnote is deemed a worthwhile addition, otherwise feel free to make this PR a one word change (number -> code) and push. |
|
Thanks - sorry about the delay - only just noticed this one. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor nit - for consistency. I suspect 'revision number' was their original name, when they were purely sequential.
Also mention this register stores other things too - currently 3 features not related to the revision code. Not sure if this is really needed, but it improves the 'discoverability' of this information slightly.