Skip to content

Conversation

@aallan
Copy link
Contributor

@aallan aallan commented May 2, 2022

Pulled in from https://datasheets.raspberrypi.com/iqaudio/iqaudio-product-brief.pdf this is a stub for documentation around the IQ audio boards. This has a bunch of problems ranging from stylistic issues through structural ones. On the other hand it's somewhere to start from, and I'm pondering whether I should just merge this as is rather than keep it on a branch. This PR to serve as a placeholder so I remember I'm going to want to merge it at some point.

@aallan aallan self-assigned this May 2, 2022
@aallan aallan added the paused Waiting for other things to happen. label May 11, 2022
Copy link
Contributor

@RuffaloLavoisier RuffaloLavoisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my humble opinion, I think we need to get rid of \n that breaks words.

@lurch
Copy link
Contributor

lurch commented May 22, 2022

This is very early-stage documentation, and will likely be seeing major changes before we publish it. So not really worth commenting on it yet @RuffaloLavoisier 😉

@lurch lurch marked this pull request as draft May 22, 2022 20:25
@raspberrypi raspberrypi deleted a comment from RuffaloLavoisier May 23, 2022
@raspberrypi raspberrypi deleted a comment from RuffaloLavoisier May 23, 2022
@raspberrypi raspberrypi deleted a comment from RuffaloLavoisier May 23, 2022
@raspberrypi raspberrypi deleted a comment from RuffaloLavoisier May 23, 2022
@raspberrypi raspberrypi deleted a comment from RuffaloLavoisier May 23, 2022
@raspberrypi raspberrypi deleted a comment from RuffaloLavoisier May 23, 2022
@raspberrypi raspberrypi deleted a comment from RuffaloLavoisier May 23, 2022
@raspberrypi raspberrypi deleted a comment from RuffaloLavoisier May 23, 2022
@raspberrypi raspberrypi deleted a comment from RuffaloLavoisier May 23, 2022
@raspberrypi raspberrypi deleted a comment from RuffaloLavoisier May 23, 2022
@raspberrypi raspberrypi deleted a comment from RuffaloLavoisier May 23, 2022
@raspberrypi raspberrypi deleted a comment from RuffaloLavoisier May 23, 2022
Lost quite a lot of verbiage. 

Leaving line 48 for now; to revisit when we've moved things over.
Style, losing some bumph.
General tidy, style, spelling, spot of rewording, removed note about the specific Digikey part number of the boards' header.
@aallan aallan removed the ready to merge The OP says this PR is ready to merge? Anyone object? label Oct 18, 2022
@aallan
Copy link
Contributor Author

aallan commented Oct 18, 2022

Waiting for #2639, #2641, #2642, #2643, #2644, #2647, #2648, #2649, #2650, and #2651 to merge.

@ghost
Copy link

ghost commented Oct 18, 2022

Waiting for ... #2647 ... to merge.

Don't need to wait for that one - it's unrelated.

@aallan aallan merged commit ec863ea into develop Oct 19, 2022
@aallan aallan deleted the iqaudio branch October 19, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants