Skip to content

Conversation

@gituser789
Copy link
Contributor

The new headless setup was introduced into the documentation.
But this hint was missing in the ssh-server section.

A user just looking into the ssh-server part does not know about this new feature, which was introduced april 2022.

Copy link
Contributor

@aallan aallan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tend not to add specific dates into the documentation as this ages quickly into being irrelevant information.

@gituser789
Copy link
Contributor Author

Updated according your hint.

aallan
aallan previously approved these changes Sep 29, 2022
@aallan aallan dismissed their stale review September 29, 2022 10:07

Build failed

@aallan
Copy link
Contributor

aallan commented Sep 29, 2022

Automated build fails, please correct the errors and we'll look at the PR again.

Traceback (most recent call last):
  File "/home/runner/work/documentation/documentation/scripts/create_nav.py", line 123, in <module>
    raise Exception("{} has an internal-link to {} but that destination doesn't exist".format(filepath, linkinfo['url']))
Exception: documentation/asciidoc/computers/remote-access/secure-shell.adoc has an internal-link to computers/headless.adoc but that destination doesn't exist

@gituser789
Copy link
Contributor Author

internal linking is fixed

@gituser789
Copy link
Contributor Author

Hi,
i fixed the internal linking. Can you review the PR again?

@aallan
Copy link
Contributor

aallan commented Oct 6, 2022

There is not an application called "Configuring a User"?

@gituser789
Copy link
Contributor Author

Updated.

@gituser789
Copy link
Contributor Author

One link was changed by mistake, this was reversed.

@gituser789
Copy link
Contributor Author

Sorry for some trouble. May it is possible to run the tests before the review?

The documentation linkin should work like
main-adoc-file.adoc#section[name]

I was mixing different link styles. I updated it now to
configuration.adoc#configuring-a-user[Configuring a User]
and the section [[configuring-a-user]] was introduced inside headless.adoc, what is linked in configuration.adoc

Please review again.

@aallan aallan merged commit b72a8ba into raspberrypi:develop Oct 6, 2022
@lurch lurch mentioned this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants