Skip to content

Conversation

timg236
Copy link
Contributor

@timg236 timg236 commented Oct 26, 2022

No description provided.

Copy link
Contributor

@aallan aallan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go?

@aallan aallan added the ready to merge The OP says this PR is ready to merge? Anyone object? label Oct 26, 2022
46 -- WVC1 decode key +
47-54 -- SHA256 of RSA public key for secure-boot +
55 -- secure-boot flags (reserved for use by the bootloader) +
56-63 -- 256bit device specific private key +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor quibble, but IMHO 256bit should be 256-bit. And perhaps a hyphen between 'device' and 'specific' ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it matters. Would be better to publish now since the code is out there but feel free to edit directly

This operation is unlikely to be useful for the vast majority of users, and is irreversible.

=== Device specific private key
Eight rows of OTP (256bits) are available for use as a device-specific private key. This is intended to support file-system encryption.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space between '256' and 'bits' please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above :)

@aallan
Copy link
Contributor

aallan commented Oct 26, 2022

Okay, lets merge.

@aallan aallan merged commit ca52248 into raspberrypi:develop Oct 26, 2022
lurch added a commit that referenced this pull request Oct 28, 2022
 * Tidy up hyphenation around 'bit', following on from comments in #2672
 * 64-bit kernel is no longer beta
@lurch lurch mentioned this pull request Oct 28, 2022
@timg236 timg236 deleted the otp-device-specific-private-key branch February 25, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation enhancement ready to merge The OP says this PR is ready to merge? Anyone object?

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants