Explicitly prefix hexadecimal values with 0x in New Style Revision Codes table #4025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-contino
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This totally threw me for a while, because I on my rpi 400 I was retrieving the value 19 for the "Type" field, which appeared to be for the rpi 500. It was only later I noticed that the field values were in hex (so 19 in the table for the rpi 500 was really 0x19, i.e. 25, and the raspberry pi value listed as 13 was actually 0x13, i.e. 19). Since other people could easily be confused by this, I figured it was better to be explicit and prefix the hex values with
0xwhich is reasonably conventional. The way I eventually noticed the numbers in the table weren't decimal was when I noticed a valuefabove. Thanks!