dtoverlays: Fix pi3-disable overlays#2761
dtoverlays: Fix pi3-disable overlays#2761mbgg wants to merge 1 commit intoraspberrypi:rpi-4.14.yfrom
Conversation
The root node definition of pi3-disable-wifi and pi3-disable-bt is not correct. This breaks the overlays. This patch fixes the root note definition. Signed-off-by: Matthias Brugger <mbrugger@suse.com>
|
Problem also present in rpi-4.20.y |
|
dtc compiles it and the firmware applies it, so in what way are the overlays broken? |
|
I generate the dtbo using When I apply the overlay, it doesn't work. When I fix the root node definition to comply with the devicetree spec [1] it gets correctly applied. Apart, all other overlays have the rootnode defined like this, which gives a hint that something is fishy with this files. [1] https://github.com/devicetree-org/devicetree-specification/blob/master/source/source-language.rst |
|
Using two different versions of dtc, with your parameters, both are happy without the space between the Please upload a "bad" compiled overlay (.dtbo) and a "good" one, so I can see the difference. |
|
error 40, 40 centimeters in front of the display. These overlays are actually working for me as well. Sorry for the noise. |
The root node definition of pi3-disable-wifi and
pi3-disable-bt is not correct. This breaks the
overlays. This patch fixes the root note definition.
Signed-off-by: Matthias Brugger mbrugger@suse.com