Skip to content

dtoverlays: Fix pi3-disable overlays#2761

Closed
mbgg wants to merge 1 commit intoraspberrypi:rpi-4.14.yfrom
mbgg:4.14-fix-pi3-disable-overlay
Closed

dtoverlays: Fix pi3-disable overlays#2761
mbgg wants to merge 1 commit intoraspberrypi:rpi-4.14.yfrom
mbgg:4.14-fix-pi3-disable-overlay

Conversation

@mbgg
Copy link
Copy Markdown
Contributor

@mbgg mbgg commented Nov 20, 2018

The root node definition of pi3-disable-wifi and
pi3-disable-bt is not correct. This breaks the
overlays. This patch fixes the root note definition.

Signed-off-by: Matthias Brugger mbrugger@suse.com

The root node definition of pi3-disable-wifi and
pi3-disable-bt is not correct. This breaks the
overlays. This patch fixes the root note definition.

Signed-off-by: Matthias Brugger <mbrugger@suse.com>
@mbgg
Copy link
Copy Markdown
Contributor Author

mbgg commented Nov 20, 2018

Problem also present in rpi-4.20.y

@pelwell
Copy link
Copy Markdown
Contributor

pelwell commented Nov 20, 2018

dtc compiles it and the firmware applies it, so in what way are the overlays broken?

@mbgg
Copy link
Copy Markdown
Contributor Author

mbgg commented Nov 20, 2018

I generate the dtbo using
dtc -R 0 -p 0 -@ -H epapr -I dts -O dtb [...]

When I apply the overlay, it doesn't work. When I fix the root node definition to comply with the devicetree spec [1] it gets correctly applied. Apart, all other overlays have the rootnode defined like this, which gives a hint that something is fishy with this files.

[1] https://github.com/devicetree-org/devicetree-specification/blob/master/source/source-language.rst

@pelwell
Copy link
Copy Markdown
Contributor

pelwell commented Nov 20, 2018

Using two different versions of dtc, with your parameters, both are happy without the space between the / and the { - they produce identical output. From what I can see, the grammar does not demand whitespace except to separate elements that might otherwise be treated together as one. Since the brace is not part of any other syntax element, the presence of whitespace between it and the preceding path is completely optional.

Please upload a "bad" compiled overlay (.dtbo) and a "good" one, so I can see the difference.

@mbgg
Copy link
Copy Markdown
Contributor Author

mbgg commented Nov 21, 2018

error 40, 40 centimeters in front of the display. These overlays are actually working for me as well. Sorry for the noise.

@mbgg mbgg closed this Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants