`fb_sh1106` driver not compiled in by default; consider enabling?

[CRImier]

On default Raspbian Lite install, fb_ssd1306 kernel module is installed but fb_sh1106 (almost-identical display but cheaper and more popular) is not available. Has been happening for a couple of releases now. We could compile and add it by default in ZeroPhone SD card images, but it's a lot of hassle compared to what I'm proposing - setting it to 'y' by default in upstream and allowing all the other users to use it, too.

pi@zerophone:~/ZPUI $ zgrep "SH1106" /proc/config.gz
# CONFIG_FB_TFT_SH1106 is not set

System

raspinfo command not installed by default on Raspbian Lite. Uname: Linux zerophone 4.14.98+ #1200 Tue Feb 12 20:11:02 GMT 2019 armv6l GNU/Linux

PRETTY_NAME="Raspbian GNU/Linux 9 (stretch)"
NAME="Raspbian GNU/Linux"
VERSION_ID="9"
VERSION="9 (stretch)"
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"

[pelwell]

We are very unlikely to build this driver into the kernel - we aim to keep the core kernel as small as possible - but adding the module to the standard builds sounds reasonable. @popcornmix?

[CRImier]

Ah sure, sorry, what I meant to propose is "m", same as fb_ssd1306.

[popcornmix]

No objection to adding this as a module.

[pelwell]

It's added (7f26b44), and will be in the next firmware release.

[CRImier]

Thank you! When will the next FW release be, if that's not a secret? How will it be distributed, apt install or rpi-update? (wasn't rpi-update outdated?)

[pelwell]

Firmware releases are usually no more than a week apart, and they are available first via rpi-update.

[popcornmix]

@CRImier this option is in latest rpi-update kernel. Can you test close if happy.