Touchscreen spurious event fix #2207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelwell
requested changes
Sep 22, 2017
Contributor
pelwell
left a comment
pelwell
left a comment
There was a problem hiding this comment.
This looks fine apart from the formatting issue, and the lack of "Signed-off-by:".
| input_mt_slot(ts->input_dev, touchid); | ||
| input_mt_report_slot_state(ts->input_dev, MT_TOOL_FINGER, 1); | ||
| if (event_id == FTS_TOUCH_CONTACT || event_id == FTS_TOUCH_DOWN) | ||
| { |
Contributor
There was a problem hiding this comment.
This brace belongs on the previous line. If it doesn't fit, split the predicate after the ||.
| { | ||
| int x = (((int) regs.point[i].xh & 0xf) << 8) + regs.point[i].xl; | ||
| int y = (((int) regs.point[i].yh & 0xf) << 8) + regs.point[i].yl; | ||
| int touchid = (regs.point[i].yh >> 4) & 0xf; |
There was a problem hiding this comment.
Is this value going to be correct? Looks like you've got 2 bits for touchid and 2 bits for touch number... But this is supposed to be a five touch device, in fact I believe the old one was 10 point...
Contributor
Author
|
I've not changed that bit of code - just added the conditional. Touch ID is
4 bits, event ID is 2 bit according to datasheet.
Forgot this was linux, I'll update the PR to coding standard.
…On 22 September 2017 at 10:43, Gordon Hollingworth ***@***.*** > wrote:
***@***.**** commented on this pull request.
------------------------------
In drivers/input/touchscreen/rpi-ft5406.c
<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_raspberrypi_linux_pull_2207-23discussion-5Fr140452534&d=DwMCaQ&c=DpyQ_ftY536pf7wCBQXXU58xADDRY77THQzJu1OmzOo&r=w09_2ePv8G3zRjoV19Wm1Q6rI7CDlOns4PuRv2hHkek&m=rxV7dDGaZ0PYOHzygMO_n0RcBh9n9cOHRtHCTeO1o0Q&s=_SIXFUzuPniD30yl755GtomTgq4nXA90VNb0bsiMqVw&e=>
:
> @@ -81,18 +84,21 @@ static int ft5406_thread(void *arg)
int x = (((int) regs.point[i].xh & 0xf) << 8) + regs.point[i].xl;
int y = (((int) regs.point[i].yh & 0xf) << 8) + regs.point[i].yl;
int touchid = (regs.point[i].yh >> 4) & 0xf;
Is this value going to be correct? Looks like you've got 2 bits for
touchid and 2 bits for touch number... But this is supposed to be a five
touch device, in fact I believe the old one was 10 point...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_raspberrypi_linux_pull_2207-23pullrequestreview-2D64529328&d=DwMCaQ&c=DpyQ_ftY536pf7wCBQXXU58xADDRY77THQzJu1OmzOo&r=w09_2ePv8G3zRjoV19Wm1Q6rI7CDlOns4PuRv2hHkek&m=rxV7dDGaZ0PYOHzygMO_n0RcBh9n9cOHRtHCTeO1o0Q&s=rIHysR7rpUw99diffbp53KezY5DJyFs4i1HYM8O4f4s&e=>,
or mute the thread
<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ADqrHQIyHDNyZ-5F-2DevvAp9X8SBE-5FsOoZIks5sk4FCgaJpZM4PgdEJ&d=DwMCaQ&c=DpyQ_ftY536pf7wCBQXXU58xADDRY77THQzJu1OmzOo&r=w09_2ePv8G3zRjoV19Wm1Q6rI7CDlOns4PuRv2hHkek&m=rxV7dDGaZ0PYOHzygMO_n0RcBh9n9cOHRtHCTeO1o0Q&s=xrxeEH0FEQWDVG439ByJLg8-b6yG9KAoIOmgIiB_PwA&e=>
.
--
James Hughes
Principal Software Engineer,
Raspberry Pi (Trading) Ltd
|
JamesH65
force-pushed
the
TouchscreenFix
branch
from
308d925 to
6700982
Compare
Touchscreen driver was not checking event type, which meant bad coords that arrived with the finger up event were being used, causing this spurious coordinate event. Fix is to ignore all finger up events. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
JamesH65
force-pushed
the
TouchscreenFix
branch
from
6700982 to
78c5c39
Compare
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Sep 22, 2017
kernel: Touchscreen spurious event fix See: raspberrypi/linux#2207 firmware: tvservice: Avoid unmatched reference counting on attach/unplugged events See: #875
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Sep 22, 2017
kernel: Touchscreen spurious event fix See: raspberrypi/linux#2207 firmware: tvservice: Avoid unmatched reference counting on attach/unplugged events See: raspberrypi/firmware#875
Contributor
Author
|
Thanks Dom.
…On 22 September 2017 at 17:34, popcornmix ***@***.***> wrote:
Merged #2207 <#2207>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2207 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADqrHVJnJhIJmQ2BewDt-xKKwpxLnI-Zks5sk-GcgaJpZM4PgdEJ>
.
--
James Hughes
Principal Software Engineer,
Raspberry Pi (Trading) Ltd
|
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Sep 24, 2017
kernel: Touchscreen spurious event fix See: raspberrypi/linux#2207 firmware: tvservice: Avoid unmatched reference counting on attach/unplugged events See: #875
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Sep 24, 2017
kernel: Touchscreen spurious event fix See: raspberrypi/linux#2207 firmware: tvservice: Avoid unmatched reference counting on attach/unplugged events See: raspberrypi/firmware#875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Touchscreen driver was not checking event type,
which meant bad coords that arrived with the
finger up event were being used, causing this
spurious coordinate event.
Fix is to ignore all finger up events.