Skip to content

Conversation

@tmm1
Copy link

@tmm1 tmm1 commented Aug 22, 2019

@tmm1 tmm1 marked this pull request as ready for review August 22, 2019 23:20
@tmm1
Copy link
Author

tmm1 commented Aug 22, 2019

I tested this and it works as expected!

Copy link
Contributor

@6by9 6by9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks fine other than the one comment made below.

I'd like to do a quick test for myself, and also check that it is checkpatch clean, but otherwise that's my only comment.

…_FRAME

fixes #3171

Signed-off-by: Aman Gupta <aman@tmm1.net>
@tmm1
Copy link
Author

tmm1 commented Aug 23, 2019

Ran checkpatch and fixed this issue:

CHECK: Alignment should match open parenthesis
#2373: FILE: drivers/staging/vc04_services/bcm2835-codec/bcm2835-v4l2-codec.c:2373:
+		v4l2_ctrl_new_std(hdl, &bcm2835_codec_ctrl_ops,
+					V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME,

@6by9
Copy link
Contributor

6by9 commented Aug 23, 2019

Thank you!
I'm good with these changes, but I'll let @popcornmix or @pelwell review them as well.

@popcornmix popcornmix merged commit 174fcab into raspberrypi:rpi-4.19.y Aug 23, 2019
@tmm1
Copy link
Author

tmm1 commented Aug 24, 2019

Thanks!

How often are new kernels built for rpi-update?

@6by9
Copy link
Contributor

6by9 commented Aug 24, 2019

Depends on what changes have been made, but typically between 2 and 14 days. Most frequently it is with upstream kernel bumps.

popcornmix added a commit to raspberrypi/firmware that referenced this pull request Aug 28, 2019
kernel: watchdog: bcm2835_wdt: Fix module autoload
See: raspberrypi/linux#3187

kernel: staging: bcm2835-codec: remove unnecessary padding on encoder input
See: raspberrypi/linux#3179

kernel: staging: bcm2835-codec: add support for V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME
See: raspberrypi/linux#3175

firmware: AWB: Fix for manual WB settings in capture
See: #1215
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Aug 28, 2019
kernel: watchdog: bcm2835_wdt: Fix module autoload
See: raspberrypi/linux#3187

kernel: staging: bcm2835-codec: remove unnecessary padding on encoder input
See: raspberrypi/linux#3179

kernel: staging: bcm2835-codec: add support for V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME
See: raspberrypi/linux#3175

firmware: AWB: Fix for manual WB settings in capture
See: raspberrypi/firmware#1215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants