drm/vc4: Correct DSI register definition #3980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelwell
reviewed
Nov 30, 2020
The DSI1_PHY_AFEC0_PD_DLANE1 and DSI1_PHY_AFEC0_PD_DLANE3 register definitions were swapped, so trying to use more than a single data lane failed as lane 1 would get powered down. (In theory a 4 lane device would work as all lanes would remain powered). Correct the definitions. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Dec 7, 2020
kernel: overlays: Add PCF85063 and PCF85063A to i2c-rtc kernel: configs: Add RTC_DRV_PCF85063=m kernel: ARM: dts: CM4 audio pins are not connected kernel: PCI: brcmstb: Advertise MSI-X support kernel: media: bcm2835-unicam: Clear clock state when stopping streaming See: raspberrypi/linux#3986 kernel: media: bcm2835-unicam: Correctly handle error states on stream on/off See: raspberrypi/linux#3984 kernel: media: i2c: imx219: Selection compliance fixes See: raspberrypi/linux#3983 kernel: drm/vc4: Correct DSI register definition See: raspberrypi/linux#3980 firmware: arm_dt: Handle parent interrupt controllers when masking firmware: config: Add cm4 and pi400 config section filters firmware: MMAL/IL/ISP component: Set the ISP boost frequency once on open firmware: sdcard: Remove legacy NOOBS support to support booting from primary partition 4 firmware: arm_loader: Move 2711 RAM to PCIe address 16GB firmware: video_decode: Add parameter to disable timestamp validation firmware: Imx477 camera tuning fixes See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=291032#p1770287 See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=291032&start=25#p1771066
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Dec 7, 2020
kernel: overlays: Add PCF85063 and PCF85063A to i2c-rtc kernel: configs: Add RTC_DRV_PCF85063=m kernel: ARM: dts: CM4 audio pins are not connected kernel: PCI: brcmstb: Advertise MSI-X support kernel: media: bcm2835-unicam: Clear clock state when stopping streaming See: raspberrypi/linux#3986 kernel: media: bcm2835-unicam: Correctly handle error states on stream on/off See: raspberrypi/linux#3984 kernel: media: i2c: imx219: Selection compliance fixes See: raspberrypi/linux#3983 kernel: drm/vc4: Correct DSI register definition See: raspberrypi/linux#3980 firmware: arm_dt: Handle parent interrupt controllers when masking firmware: config: Add cm4 and pi400 config section filters firmware: MMAL/IL/ISP component: Set the ISP boost frequency once on open firmware: sdcard: Remove legacy NOOBS support to support booting from primary partition 4 firmware: arm_loader: Move 2711 RAM to PCIe address 16GB firmware: video_decode: Add parameter to disable timestamp validation firmware: Imx477 camera tuning fixes See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=291032#p1770287 See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=291032&start=25#p1771066
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DSI1_PHY_AFEC0_PD_DLANE1 and DSI1_PHY_AFEC0_PD_DLANE3 register
definitions were swapped, so trying to use more than a single data
lane failed as lane 1 would get powered down.
(In theory a 4 lane device would work as all lanes would remain
powered).
Correct the definitions.
Signed-off-by: Dave Stevenson dave.stevenson@raspberrypi.com