Skip to content

staging/bcm2835-codec: Ensure OUTPUT timestamps are always forwarded #3998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
popcornmix merged 1 commit into from
Dec 10, 2020
Merged

staging/bcm2835-codec: Ensure OUTPUT timestamps are always forwarded #3998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions drivers/staging/vc04_services/bcm2835-codec/bcm2835-v4l2-codec.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2001,6 +2001,19 @@ static int bcm2835_codec_create_component(struct bcm2835_codec_ctx *ctx)
MMAL_PARAMETER_ZERO_COPY, &enable,
sizeof(enable));

if (dev->role == DECODE) {
/*
* Disable firmware option that ensures decoded timestamps
* always increase.
*/
enable = 0;
vchiq_mmal_port_parameter_set(dev->instance,
&ctx->component->output[0],
MMAL_PARAMETER_VIDEO_VALIDATE_TIMESTAMPS,
&enable,
sizeof(enable));
}

setup_mmal_port_format(ctx, &ctx->q_data[V4L2_M2M_SRC],
&ctx->component->input[0]);

Expand Down
3 changes: 3 additions & 0 deletions drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,6 +674,9 @@ enum mmal_parameter_video_type {

/**< Take a @ref MMAL_PARAMETER_BOOLEAN_T */
MMAL_PARAMETER_VIDEO_ENCODE_HEADERS_WITH_FRAME,

/**< Take a @ref MMAL_PARAMETER_BOOLEAN_T */
MMAL_PARAMETER_VIDEO_VALIDATE_TIMESTAMPS,
};

/** Valid mirror modes */
Expand Down