-
Notifications
You must be signed in to change notification settings - Fork 5.3k
enable several virtual devices for hosting virtual machines #4712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This kind of PR is relatively easy to approve, in that it just requests some modules to be enabled - the core kernel is unchanged. Although there are 6 new modules, they aren't huge: However, I do want you to update the PR to put the new config options into the natural order. You can do this for e.g. Once you've done that for both defconfig files you can either push the changes as a followup commit which I can then squash while merging, or squash/amend it at your end, Either way, add a comment here when you're done. |
|
The updated commit looks correct with respect to the file order, but it has lost three modules: -CONFIG_VSOCKETS_DIAG=m
-CONFIG_VSOCKETS_LOOPBACK=m
-CONFIG_VIRTIO_VSOCKETS_COMMON=mIs that intentional? |
|
That was not intentional. I am just looking into that now. will update in just a few. |
|
with the unsorted modules enabled in the defconfig the .config is configured with the correct modules enabled (specifically the 3 mentioned). When |
0d991de to
9efed45
Compare
|
It's fine - those options are implied by the others (if you look in the .config file you'll find they are still present). |
|
(I should have spotted that sooner) |
|
I created another PR for 5.15.y Thanks for the help |
kernel: enable several virtual devices for hosting virtual machines See: raspberrypi/linux#4712 kernel: configs: add LEDS_PWM=y See: raspberrypi/linux#4668 kernel: configs: add CONFIG_HID_PLAYSTATION=m and CONFIG_PLAYSTATION_FF=y See: raspberrypi/linux#4721 kernel: configs: Add USB gadget support (for Zero 2 W) See: #1654
kernel: enable several virtual devices for hosting virtual machines See: raspberrypi/linux#4712 kernel: configs: add LEDS_PWM=y See: raspberrypi/linux#4668 kernel: configs: add CONFIG_HID_PLAYSTATION=m and CONFIG_PLAYSTATION_FF=y See: raspberrypi/linux#4721 kernel: configs: Add USB gadget support (for Zero 2 W) See: raspberrypi/firmware#1654
This enable several features used for hosting virtual machines. The LXD platform specifically use these features.
LXD specifically targets Raspberry Pi as a platform
Enabling these features makes it easier for OS packagers to include functional LXD on Raspberry Pi easily.