Pisound Micro: Workaround for snd_soc_dai_set_tdm_slot with slots=0 #6880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though it's documented that specifying slots=0 can be used to disable the TDM mode, error checking introduced in 6.12.31 version broke this, therefore, for the time being, a workaround is to provide a xlate_tdm_slot_mask operation implementation to return 0 instead of -EINVAL as it does in case slots argument is 0. Signed-off-by: Giedrius Trainavičius <giedrius@blokas.io>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jun 5, 2025
kernel: Add support for the IMX283 on Raspberry Pi platforms See: raspberrypi/linux#6869 kernel: Pisound Micro: Workaround for snd_soc_dai_set_tdm_slot with slots=0 See: raspberrypi/linux#6880 kernel: add rtw88/rtw89 drivers See: raspberrypi/linux#6881 kernel: configs: arm64: Remove CONFIG_USB_DWCOTG See: raspberrypi/linux#6883
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jun 5, 2025
kernel: Add support for the IMX283 on Raspberry Pi platforms See: raspberrypi/linux#6869 kernel: Pisound Micro: Workaround for snd_soc_dai_set_tdm_slot with slots=0 See: raspberrypi/linux#6880 kernel: add rtw88/rtw89 drivers See: raspberrypi/linux#6881 kernel: configs: arm64: Remove CONFIG_USB_DWCOTG See: raspberrypi/linux#6883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though it's documented that specifying slots=0 can be used to disable the TDM mode, error checking introduced in 6.12.31 version broke this, therefore, for the time being, a workaround is to provide a xlate_tdm_slot_mask operation implementation to return 0 instead of -EINVAL as it does in case slots argument is 0.
I've reported it to ALSA list:
https://mailman.alsa-project.org/hyperkitty/list/alsa-devel@alsa-project.org/message/DDSGL446HGUPXIAMIQXUULJ4EPHZTO26/