pwm: rp1: Silently correct illegal values #7133
Merged
+21
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the need for the user to know the limitations of this PWM implementation by adjusting configuration requests to be the closest acceptable value. Add a get_state method so that the actual values can be queried. Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Correct the set_period method to pass (period - 1), as required by the PIO state machine. Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix
approved these changes
Nov 11, 2025
Contributor
Author
|
Merging to get some wider testing. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Nov 14, 2025
kernel: overlays: Add vec-gpio-pi5-overlay See: raspberrypi/linux#7127 kernel: drivers: i2c: imx708: Use pm_runtime_use_autosuspend() See: raspberrypi/linux#7128 kernel: mmc: Relax the 50MHz overclock check See: raspberrypi/linux#7135 kernel: pwm: rp1: Silently correct illegal values See: raspberrypi/linux#7133
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Nov 14, 2025
kernel: overlays: Add vec-gpio-pi5-overlay See: raspberrypi/linux#7127 kernel: drivers: i2c: imx708: Use pm_runtime_use_autosuspend() See: raspberrypi/linux#7128 kernel: mmc: Relax the 50MHz overclock check See: raspberrypi/linux#7135 kernel: pwm: rp1: Silently correct illegal values See: raspberrypi/linux#7133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the need for the user to know the limitations of this PWM
implementation by adjusting configuration requests to be the closest
acceptable value. Add a get_state method so that the actual values can
be queried.
Also, correct the set_period method to pass (period - 1), as required by the
PIO state machine.
See: #7131