Fix PICO_DEOPTIMIZED_DEBUG not updating compiler flags #1620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting CMAKE_${LANG}_FLAGS_DEBUG_INIT specifically only sets the flags for the Debug config the first time it is configured by CMake, pulling the initially-configured flags from CMakeCache.txt on subsequent configurations. This causes PICO_DEOPTIMIZED_DEBUG to not have any effect after the initial configuration, causing breakpoint issues when debugging certain functions.
Changing the CMake variable to CMAKE_${LANG}_FLAGS_DEBUG enables the flags to be updated every configuration, no longer depending on the cache. We also must append the debug flags which were set prior to this file to maintain functional parity with the behaviour of CMAKE_${LANG}_FLAGS_DEBUG_INIT.
See Issue raspberrypi#1618 in the primary repository for further details.
Fixes raspberrypi#1618
Contributor
Author
|
Setting to draft as I've identified a bug where the initial configuring produces |
Contributor
Author
|
Okay, I understand the problem. It appears that when CMake is provided string(APPEND CMAKE_${lang}_FLAGS_DEBUG_INIT " -g")This gets appended after calling: project(project-name)Since Looks like unsetting |
Setting CMAKE_${LANG}_FLAGS_DEBUG_INIT specifically only sets the flags for the Debug config the first time it is configured by CMake, pulling the initially-configured flags from CMakeCache.txt on subsequent configurations. This causes PICO_DEOPTIMIZED_DEBUG to not have any effect after the initial configuration, causing breakpoint issues when debugging certain functions.
Clearing the cache of the debug flags allows the flags to be updated every configuration, and appended to appropriately (such as with "-g").
See Issue raspberrypi#1618 and the comments of Pull Request raspberrypi#1620 for further details.
Fixes raspberrypi#1618
Contributor
Author
|
If accepted, I'd recommend squashing before merge as the first commit contains bugs. |
recursivenomad
added a commit
to recursivenomad/pico-sdk
that referenced
this pull request
Jan 30, 2024
Optimizing a debug build with PICO_DEOPTIMIZED DEBUG disabled (the current default) results in breakpoints not being possible in certain functions. This change makes the default behaviour of PICO_DEOPTIMIZED_DEBUG to be enabled, so that debug builds will fully work as expected when no explicit value for the option is passed. Since the cache stores the default value of PICO_DEOPTIMIZED DEBUG, you will need to delete the CMakeCache.txt previously generated in your project directory for this change to default behaviour to take effect in existing projects. This commit is related to pull request raspberrypi#1620 in the primary repository. See Issue raspberrpi#1618 in the primary repository for additional context.
kilograham
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
CMAKE_${LANG}_FLAGS_DEBUG_INITspecifically only sets the flags for the Debug config the first time it is configured by CMake, pulling the initially-configured flags fromCMakeCache.txton subsequent configurations. This causesPICO_DEOPTIMIZED_DEBUGto not have any effect after the initial configuration, causing breakpoint issues when debugging certain functions.Changing the CMake variable to
CMAKE_${LANG}_FLAGS_DEBUGenables the flags to be updated every configuration, no longer depending on the cache. We also must append the debug flags which were set prior to this file to maintain functional parity with the behaviour ofCMAKE_${LANG}_FLAGS_DEBUG_INIT.See Issue #1618 for further details.
Fixes #1618